NotificationsYou must be signed in to change notification settings
Fork227
Star2k

Auto Optimizer#1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

shaahji wants to merge1 commit intomain

base:main

Choose a base branch

fromshaahji/autoopt

Open

Auto Optimizer#1801

shaahji wants to merge1 commit intomainfromshaahji/autoopt

Conversation

Copy link

Contributor

shaahji commentedApr 28, 2025•
edited
Loading

Auto Optimizer

Redo auto-optimizer logic to simplify and use search engine.
Also, update the auto-opt CLI command to use AutoOptimizer.

Checklist before requesting a review

Add unit tests for this change.
Make sure all tests can pass.
Update documents if necessary.
Lint and apply fixes to your code by runninglintrunner -a
Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
Is this PR including examples changes? If yes, please remember to updateexample documentation in a follow-up PR.

(Optional) Issue link

github-advanced-securitybot found potential problems

Apr 28, 2025

View reviewed changes

olive/auto_optimizer/auto_optimizer.py FixedShow fixedHide fixed

devang-ml approved these changes

Apr 28, 2025

View reviewed changes

olive/auto_optimizer/auto_optimizer.py OutdatedShow resolvedHide resolved

olive/olive_config.json OutdatedShow resolvedHide resolved

olive/auto_optimizer/auto_optimizer.py OutdatedShow resolvedHide resolved

devang-ml requested changes

Apr 29, 2025

View reviewed changes

Copy link

Contributor

devang-ml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's quickly make these changes.

shaahji force-pushed theshaahji/autoopt branch 2 times, most recently fromc280226 to6dc0579Compare

May 5, 2025 12:07

github-advanced-securitybot found potential problems

May 5, 2025

View reviewed changes

test/unit_test/auto_optimizer/test_auto_optimizer.py FixedShow fixedHide fixed

shaahji force-pushed theshaahji/autoopt branch 2 times, most recently from4b48cf0 toa2ab5b8Compare

May 5, 2025 20:25

shaahji changed the title~~Auto Optimizer - Work In Progress~~Auto Optimizer

May 5, 2025

shaahji marked this pull request as ready for review

May 5, 2025 20:26

shaahji force-pushed theshaahji/autoopt branch 2 times, most recently from7e093d2 to393a904Compare

May 6, 2025 19:46

devang-ml reviewed

May 6, 2025

View reviewed changes

examples/llama2/llama2_auto_opt.json

		"use_model_builder": true,
		"train_data_config": "wikitext2_train",
		"calibration_data_config": "transformer_token_dummy_data",
		"accelerator": { "accelerator_type": "cpu", "execution_provider": "CPUExecutionProvider" },

Copy link

Contributor

devang-mlMay 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we just use theaccelerator from thesystem ?

Copy link

ContributorAuthor

shaahjiMay 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Olive config can have multiple system defined especially for cases where passes can use a separate host. That would make choosing the accelerator ambiguous.

olive/passes/onnx/peephole_optimizer.py

		return False

		if accelerator_spec.execution_provider == "QNNExecutionProvider":
		logger.info("QNNExecutionProvider doesn't support optimized model.")

Copy link

Contributor

devang-mlMay 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since peephole optimizations are EP independent, why do we need this check?

Copy link

ContributorAuthor

shaahjiMay 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is carry forward from current auto-opt cli implementation.

Olive/olive/cli/auto_opt.py

Lines 320 to 322 in59bfe00

	# qnn ep might not supported optimized model
	# will re-enable it if needed in the future
	passes_to_remove.update(["transformer_optimizer","peephole_optimizer"])

olive/auto_optimizer/auto_optimizer.py OutdatedShow resolvedHide resolved

xiaoyu-work reviewed

May 6, 2025

View reviewed changes

examples/llama2/llama2_auto_opt.json OutdatedShow resolvedHide resolved

shaahji force-pushed theshaahji/autoopt branch 7 times, most recently from0a7a890 to3d7aaeeCompare

May 9, 2025 19:56

Auto Optimizer - Use search engine

00e9e5f

Redo auto-optimizer logic to simplify and use search engine.

shaahji force-pushed theshaahji/autoopt branch from3d7aaee to00e9e5fCompare

June 2, 2025 19:39

Labels

None yet

3 participants

Movatterモバイル変換

Auto Optimizer#1801

Are you sure you want to change the base?

Auto Optimizer#1801

Uh oh!

Conversation

shaahji commentedApr 28, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Auto Optimizer

Checklist before requesting a review

(Optional) Issue link

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devang-ml left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devang-mlMay 6, 2025

Choose a reason for hiding this comment

Uh oh!

shaahjiMay 7, 2025

Choose a reason for hiding this comment

Uh oh!

devang-mlMay 6, 2025

Choose a reason for hiding this comment

Uh oh!

shaahjiMay 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shaahji commentedApr 28, 2025•
edited
Loading