- Notifications
You must be signed in to change notification settings - Fork1.1k
umqtt.robust: let reconnect() call the connect() method of the top class#669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@andrewleech, if you had a moment to review + comment, I'd appreciate it. |
Those examples look great! |
Anything else I ought to do / address before this can go forward for merge? |
Uh oh!
There was an error while loading.Please reload this page.
This allows overriding of the connect() method by a subclass as per theincluded examples: `example_lwt_robust.py` and `example_resubscribe_robust.py`. Co-authored by: Ian Cotter-Llewellyn <ian_llewellyn@hotmail.com> Date: Thu May 25 11:42:20 2023 +0100
8d4503b to1d1f6acCompareHey guys, any chance we can progress this to merge? If there's anything else to do beforehand, let me know. |
@andrewleech,@dpgeorge, you guys seem like the people to be pestered! 🤣 (sorry). Are there reasons this PR shouldn't progress? If there's anything more I should do, please do tell. |
Just polling to see if this can go ahead. |
Uh oh!
There was an error while loading.Please reload this page.
This allows overriding of the
connect()method by a subclass as per the included examples:example_lwt_robust.pyandexample_resubscribe_robust.py.Fixes#186 (by enabling
example_resubscribe_robust.py)Supersedes PR#195 (original source file moved, examples added)