- Notifications
You must be signed in to change notification settings - Fork1.1k
python-ecosys/aiohttp: Fix partial reads.#1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
python-ecosys/aiohttp: Fix partial reads.#1034
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I think it may be better to use async def read(self, sz=-1):+ if sz > 0:+ return self._decode(await self.content.readexactly(sz)) return self._decode(await self.content.read(sz)) |
Hooo yes ! This is will clearly make the whole module more robust. I did the changes and did some testing and everything looks good so far |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, thanks.
Fixes issue#1012.Signed-off-by: FuNK3Y <fun__key@hotmail.com>
b95ca24 intomicropython:masterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This one has been inspired by#1012 and should solve it
This problem does not only affect websockets. I experienced similar troubles when reading a JSON payload of ~6.5k from an ESP32.