- Notifications
You must be signed in to change notification settings - Fork27
Use micropython from new build location during build#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The MicroPython project changed their CI scripts slightlywhich resulted in the unix port binary being output to asubdirectory (build-standard) instead of the currentdirectory as before. This broke our build process.This commit updates our build script to search forthe micropython binary in the correct subdirectory.Fixesmicropython#81
wnienhaus commentedAug 20, 2022
As a side note, I wondered if we should lock ourselves to a specific tag/version of MicroPython in our build, to avoid breaking our build, when the Micropython project makes similar changes in the future. On the other hand it's nice knowing that our code works with the latest MicroPython. Then again, by locking to a specific version and manually changing this every so often, it would prevent the build from breaking at an inconvenient time (when we might not have time to fix it), and instead let us choose when to change version and deal with the potential issues. @ThomasWaldmann - any experience/suggestion on which would be the better approach? |
mattytrentini commentedAug 21, 2022
How about tagging releases in lock-step with MicroPython releases? And follow MicroPython master on this master? |
wnienhaus commentedAug 21, 2022
@mattytrentini Hmm. Not sure I fully understand. Do you mean that we should tag this repo and create a release, every time MicroPython has a release, whether we had any changes or not? And should we maintain 2 branches, one master and one for releases, so we can follow micropython's master from our master branch, and follow the specific MicroPython branch we want for each release in our release branch? It feels a bit cumbersome, but likely I am overcomplicating it in my head, and you had something much simpler in mind? |
wnienhaus commentedAug 30, 2022
@mattytrentini I created an issue to deal with following MicroPython releases vs our build process (#83), to tackle that topic there, while I can so long merge this PR as is. |
The MicroPython project changed their CI scripts slightly, which resulted in the unix port binary being output to a subdirectory (
build-standard) instead of the current directory as before. This broke our build process.This commit updates our build script to search for the
micropythonbinary in the correct subdirectory.Fixes#81