- Notifications
You must be signed in to change notification settings - Fork27
support the ';' line separator character, aka statement separator#51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
binutils-esp32ulp treats the ';' character as a statement separator.Multiple statement separated by this character are treated as ifeach statement was on its own line.Note: Currently, due to the way labels are detected/handled, theremust be a space between a ';' and the next statement, if there isanother statement on the same line.This commit contributes to being able to eventually assemble theesp32ulp_all.s test from binutils-esp32ulp and allows us to dealwith this line:https://github.com/espressif/binutils-esp32ulp/blob/249ec34cc2c9574a86f3f86bbb175a863f988bcf/gas/testsuite/gas/esp32ulp/esp32/esp32ulp_all.s#L108The compat tests show how more than 1 statement on a line would beused/handled.
Collaborator
ThomasWaldmann commentedSep 28, 2021
LGTM, merged! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm now trying to send more smaller PRs - this is the first one that moves us towards being able to assemble all the currently skipped examples from the binutils-esp32ulp test suite (toresolve#49).
The esp32ulp_all.s code has a
nop;statement in it, and this commit adds support for the;which functions as a statement separator. (See the commit message ofce005e3 for more detail).Side-note: Currently, due to the way labels are handled/detected, there must be a space between a
;and the next statement, if there is another statement on the same line. The way labels are handled is another thing to be fixed (seeesp32ulp_all.s:2, where a statement follows the colon without whitespace), so a future commit may address that issue.