Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

support the ';' line separator character, aka statement separator#51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ThomasWaldmann merged 1 commit intomicropython:masterfromwnienhaus:fixes-for-v1
Sep 28, 2021

Conversation

@wnienhaus
Copy link
Collaborator

I'm now trying to send more smaller PRs - this is the first one that moves us towards being able to assemble all the currently skipped examples from the binutils-esp32ulp test suite (toresolve#49).

The esp32ulp_all.s code has anop; statement in it, and this commit adds support for the; which functions as a statement separator. (See the commit message ofce005e3 for more detail).

Side-note: Currently, due to the way labels are handled/detected, there must be a space between a; and the next statement, if there is another statement on the same line. The way labels are handled is another thing to be fixed (seeesp32ulp_all.s:2, where a statement follows the colon without whitespace), so a future commit may address that issue.

binutils-esp32ulp treats the ';' character as a statement separator.Multiple statement separated by this character are treated as ifeach statement was on its own line.Note: Currently, due to the way labels are detected/handled, theremust be a space between a ';' and the next statement, if there isanother statement on the same line.This commit contributes to being able to eventually assemble theesp32ulp_all.s test from binutils-esp32ulp and allows us to dealwith this line:https://github.com/espressif/binutils-esp32ulp/blob/249ec34cc2c9574a86f3f86bbb175a863f988bcf/gas/testsuite/gas/esp32ulp/esp32/esp32ulp_all.s#L108The compat tests show how more than 1 statement on a line would beused/handled.
@ThomasWaldmannThomasWaldmann merged commite647bcc intomicropython:masterSep 28, 2021
@ThomasWaldmann
Copy link
Collaborator

LGTM, merged!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1.0.0 milestone

2 participants

@wnienhaus@ThomasWaldmann

[8]ページ先頭

©2009-2025 Movatter.jp