Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.6k
Ensures native attr handlers process subclass attribute stores#18594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
cnadler86 wants to merge1 commit intomicropython:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+96 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fixes incorrect delegation of attribute assignment in subclassesof native types with custom attribute handlers by ensuring thehandler is invoked before storing attributes in the instancedictionary. Adds tests to verify correct behavior for bothnative and subclassed types.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #18594 +/- ##==========================================- Coverage 98.38% 98.37% -0.01%========================================== Files 171 171 Lines 22298 22313 +15 ==========================================+ Hits 21937 21950 +13- Misses 361 363 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code size report: |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect delegation of attribute assignment in subclasses of native types with custom attribute handlers by ensuring the handler is invoked before storing attributes in the instance dictionary. Adds tests to verify correct behavior for both native and subclassed types.
Fixes#18592
Testing
See test added
Trade-offs and Alternatives
TBD