Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.6k
py/misc: Add byte-swapping macros.#18542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
agatti wants to merge1 commit intomicropython:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+28 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This commit adds byte-swapping macros for 16-, 32-, and 64-bit values.Modern compilers are usually able to detect manual byte/endian swaps andwill generate optimised code sequences if they know how to do that.However, in certain situations it may be helpful to let the compilergenerate an optimised sequence if it doesn't recognise the pattern.Most compilers provide built-in byte swap operations for 16, 32, and 64bit values, accessed via "__builtin_bswap<size>", but if those are notavailable a fallback implementation is provided.Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #18542 +/- ##==========================================- Coverage 98.38% 98.38% -0.01%========================================== Files 171 171 Lines 22301 22300 -1 ==========================================- Hits 21940 21939 -1 Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code size report: |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
This PR adds byte-swapping macros for 16-, 32-, and 64-bit values.
Modern compilers are usually able to detect manual byte/endian swaps and will generate optimised code sequences if they know how to do that. However, in certain situations it may be helpful to let the compiler generate an optimised sequence if it doesn't recognise the pattern.
Most compilers provide built-in byte swap operations for 16, 32, and 64 bit values, accessed via "__builtin_bswap", but if those are not available a fallback implementation is provided.
This happens to shrink the ESP8266 port by a few bytes and speed AES-ECB operations up on that port by a tiny bit.
Testing
Besides the usual CI tests round, on an ESP8266EX the full test suite passes with the same number of errors as regular 1.27.0 master (PR to fix those coming up soon).