Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base(dc1af38) to head(da7017f).
Report is 1 commits behind head on master.

@@           Coverage Diff           @@##           master   #17338   +/-   ##=======================================  Coverage   98.54%   98.54%           =======================================  Files         169      169             Lines       21898    21898           =======================================  Hits        21579    21579             Misses        319      319

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Code size report:

   bare-arm:    +0 +0.000% minimal x86:    +0 +0.000%    unix x64:    +0 +0.000% standard      stm32:    +0 +0.000% PYBV10     mimxrt:   +16 +0.004% TEENSY40        rp2:   -24 -0.003% RPI_PICO_W       samd:   -16 -0.006% ADAFRUIT_ITSYBITSY_M4_EXPRESS  qemu rv32:    +0 +0.000% VIRT_RV32

Tested on ARDUINO_NANO_33_BLE_SENSE with the following:

>>>importtime>>>print('test');time.sleep(1)test>>>

Prior to this PR, the "test" output would not appear until after the 1 second elapsed. With this PR it now works properly, "test" is printed immediately, and then it waits 1 second before the prompt appears.

Great work@projectgus getting this hook merged to TinyUSB!

Could we now get rid ofMICROPY_LINK_TINYUSB inports/esp32/esp32_common.cmake?

Could we now get rid of MICROPY_LINK_TINYUSB in ports/esp32/esp32_common.cmake?

Oh, good catch! Have taken it out as well.

Prior to this PR, the "test" output would not appear until after the 1 second elapsed. With this PR it now works properly,

Huh, that's good! I see the nrf port of TinyUSB sometimes callsusb_defer_func() to defer an ISR callback, and this invokes the new hook function as well (previously it would have bypasseddcd_event_handler)

Pushed one more small tweak, can remove the dcd.h include line from mp_usbd.c

can remove the dcd.h include line from mp_usbd.c

Very good!

@dpgeorge I tried to replicate your test withprint('test');time.sleep(1) by fetching the actual PR and building it. It still prints "test" after one second. Did you update the tinyusb lib?