May 20, 2025
diff --git a/py/mpconfig.h b/py/mpconfig.h
 #define MICROPY_ENABLE_EXTERNAL_IMPORT (MICROPY_CONFIG_ROM_LEVEL_AT_LEAST_CORE_FEATURES)
 #endif

 // Whether to enable parsing __all__ when importing all public symbols from modules
 #ifndef MICROPY_ENABLE_MODULE_IMPORT_ALL
 #define MICROPY_ENABLE_MODULE_IMPORT_ALL (MICROPY_CONFIG_ROM_LEVEL_AT_LEAST_BASIC_FEATURES)
 #endif

 // Whether to use the POSIX reader for importing files
 #ifndef MICROPY_READER_POSIX
 #define MICROPY_READER_POSIX (0)
diff --git a/py/runtime.c b/py/runtime.c
            mp_raise_msg_varg(&mp_type_AttributeError,
                MP_ERROR_TEXT("type object '%q' has no attribute '%q'"),
                ((mp_obj_type_t *)MP_OBJ_TO_PTR(base))->name, attr);
        #if MICROPY_ENABLE_MODULE_IMPORT_ALL && MICROPY_ERROR_REPORTING >= MICROPY_ERROR_REPORTING_DETAILED
        } else if (mp_obj_is_type(base, &mp_type_module)) {
            // report errors in __all__ as done by CPython
            mp_obj_t dest_name[2];
            qstr module_name = MP_QSTR_;
            mp_load_method_maybe(base, MP_QSTR___name__, dest_name);
            if (mp_obj_is_qstr(dest_name[0])) {
                module_name = mp_obj_str_get_qstr(dest_name[0]);
            }
            mp_raise_msg_varg(&mp_type_AttributeError,
                MP_ERROR_TEXT("module '%q' has no attribute '%q'"),
                module_name, attr);
        #endif
        } else {
            mp_raise_msg_varg(&mp_type_AttributeError,
                MP_ERROR_TEXT("'%s' object has no attribute '%q'"),
 void mp_import_all(mp_obj_t module) {
    DEBUG_printf("import all %p\n", module);

    // TODO: Support __all__
    mp_map_t *map = &mp_obj_module_get_globals(module)->map;

    #if MICROPY_ENABLE_MODULE_IMPORT_ALL
    mp_map_elem_t *elem = mp_map_lookup(map, MP_OBJ_NEW_QSTR(MP_QSTR___all__), MP_MAP_LOOKUP);
    if (elem != NULL) {
        // When __all__ is defined, we must explicitly load all specified
        // symbols, possibly invoking the module __getattr__ function
        size_t len;
        mp_obj_t *items;
        mp_obj_get_array(elem->value, &len, &items);
        for (size_t i = 0; i < len; i++) {
            qstr qname = mp_obj_str_get_qstr(items[i]);
            mp_obj_t dest[2];
            mp_load_method(module, qname, dest);
            mp_store_name(qname, dest[0]);
        }
        return;
    }
    #endif

    // By default, the set of public names includes all names found in the module's
    // namespace which do not begin with an underscore character ('_')
    for (size_t i = 0; i < map->alloc; i++) {
        if (mp_map_slot_is_filled(map, i)) {
            // Entry in module global scope may be generated programmatically
diff --git a/tests/cpydiff/core_import_all.py b/tests/cpydiff/core_import_all.py
diff --git a/tests/cpydiff/modules3/__init__.py b/tests/cpydiff/modules3/__init__.py
diff --git a/tests/cpydiff/modules3/foo.py b/tests/cpydiff/modules3/foo.py
diff --git a/tests/import/import_star.py b/tests/import/import_star.py
 # test `from package import *` conventions, including __all__ support
 #
 # This test requires MICROPY_CONFIG_ROM_LEVEL_AT_LEAST_BASIC_FEATURES

 try:
    next(iter([]), 42)
 except TypeError:
    # 2-argument version of next() not supported
    # we are probably not at MICROPY_CONFIG_ROM_LEVEL_BASIC_FEATURES
    print('SKIP')
    raise SystemExit

 # 1. test default visibility
 from pkgstar_default import *

 print('visibleFun' in globals())
 print('VisibleClass' in globals())
 print('_hiddenFun' in globals())
 print('_HiddenClass' in globals())
 print(visibleFun())

 # 2. test explicit visibility as defined by __all__ (as an array)
 from pkgstar_all_array import *

 print('publicFun' in globals())
 print('PublicClass' in globals())
 print('unlistedFun' in globals())
 print('UnlistedClass' in globals())
 print('_privateFun' in globals())
 print('_PrivateClass' in globals())
 print(publicFun())
 # test dynamic import as used in asyncio
 print('dynamicFun' in globals())
 print(dynamicFun())

 # 3. test explicit visibility as defined by __all__ (as an tuple)
 from pkgstar_all_tuple import *

 print('publicFun2' in globals())
 print('PublicClass2' in globals())
 print('unlistedFun2' in globals())
 print('UnlistedClass2' in globals())
 print(publicFun2())

 # 4. test reporting of missing entries in __all__
 try:
    from pkgstar_all_miss import *

    print("missed detection of incorrect __all__ definition")
 except AttributeError as er:
    print("AttributeError triggered for bad __all__ definition")

 # 5. test reporting of invalid __all__ definition
 try:
    from pkgstar_all_inval import *

    print("missed detection of incorrect __all__ definition")
 except TypeError as er:
    print("TypeError triggered for bad __all__ definition")
diff --git a/tests/import/pkgstar_all_array/__init__.py b/tests/import/pkgstar_all_array/__init__.py
 __all__ = ['publicFun', 'PublicClass', 'dynamicFun']


 # Definitions below should always be imported by a star import
 def publicFun():
    return 1


 class PublicClass:
    def __init__(self):
        self._val = 1


 # If __all__ support is enabled, definitions below
 # should not be imported by a star import
 def unlistedFun():
    return 0


 class UnlistedClass:
    def __init__(self):
        self._val = 0


 # Definitions below should be not be imported by a star import
 # (they start with an underscore, and are not listed in __all__)
 def _privateFun():
    return -1


 class _PrivateClass:
    def __init__(self):
        self._val = -1


 # Test lazy loaded function, as used by extmod/asyncio:
 # Works with a star import only if __all__ support is enabled
 _attrs = {
    "dynamicFun": "funcs",
 }


 def __getattr__(attr):
    mod = _attrs.get(attr, None)
    if mod is None:
        raise AttributeError(attr)
    value = getattr(__import__(mod, globals(), locals(), True, 1), attr)
    globals()[attr] = value
    return value
diff --git a/tests/import/pkgstar_all_array/funcs.py b/tests/import/pkgstar_all_array/funcs.py
 def dynamicFun():
    return 777
diff --git a/tests/import/pkgstar_all_inval/__init__.py b/tests/import/pkgstar_all_inval/__init__.py
 __all__ = 42
diff --git a/tests/import/pkgstar_all_miss/__init__.py b/tests/import/pkgstar_all_miss/__init__.py
 __all__ = ('existingFun', 'missingFun')


 def existingFun():
    return None


 # missingFun is not defined, should raise an error on import
diff --git a/tests/import/pkgstar_all_tuple/__init__.py b/tests/import/pkgstar_all_tuple/__init__.py
 __all__ = ('publicFun2', 'PublicClass2')


 # Definitions below should always be imported by a star import
 def publicFun2():
    return 2


 class PublicClass2:
    def __init__(self):
        self._val = 2


 # If __all__ support is enabled, definitions below
 # should not be imported by a star import
 def unlistedFun2():
    return 0


 class UnlistedClass2:
    def __init__(self):
        self._val = 0
diff --git a/tests/import/pkgstar_default/__init__.py b/tests/import/pkgstar_default/__init__.py
 # When __all__ is undefined, star import should only
 # show objects that do not start with an underscore


 def visibleFun():
    return 42


 class VisibleClass:
    def __init__(self):
        self._val = 42


 def _hiddenFun():
    return -1


 class _HiddenClass:
    def __init__(self):
        self._val = -1
Original file line number	Diff line number	Diff line change
Expand Up		@@ -603,6 +603,11 @@
		#define MICROPY_ENABLE_EXTERNAL_IMPORT (MICROPY_CONFIG_ROM_LEVEL_AT_LEAST_CORE_FEATURES)
		#endif

		// Whether to enable parsing __all__ when importing all public symbols from modules
		#ifndef MICROPY_ENABLE_MODULE_IMPORT_ALL
		#define MICROPY_ENABLE_MODULE_IMPORT_ALL (MICROPY_CONFIG_ROM_LEVEL_AT_LEAST_BASIC_FEATURES)
		#endif

		// Whether to use the POSIX reader for importing files
		#ifndef MICROPY_READER_POSIX
		#define MICROPY_READER_POSIX (0)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1247,6 +1247,19 @@ void mp_load_method(mp_obj_t base, qstr attr, mp_obj_t *dest) {
		mp_raise_msg_varg(&mp_type_AttributeError,
		MP_ERROR_TEXT("type object '%q' has no attribute '%q'"),
		((mp_obj_type_t *)MP_OBJ_TO_PTR(base))->name, attr);
		#if MICROPY_ENABLE_MODULE_IMPORT_ALL && MICROPY_ERROR_REPORTING >= MICROPY_ERROR_REPORTING_DETAILED
		} else if (mp_obj_is_type(base, &mp_type_module)) {
		// report errors in __all__ as done by CPython
		mp_obj_t dest_name[2];
		qstr module_name = MP_QSTR_;
		mp_load_method_maybe(base, MP_QSTR___name__, dest_name);
		if (mp_obj_is_qstr(dest_name[0])) {
		module_name = mp_obj_str_get_qstr(dest_name[0]);
		}
		mp_raise_msg_varg(&mp_type_AttributeError,
		MP_ERROR_TEXT("module '%q' has no attribute '%q'"),
		module_name, attr);
		#endif
		} else {
		mp_raise_msg_varg(&mp_type_AttributeError,
		MP_ERROR_TEXT("'%s' object has no attribute '%q'"),
Expand DownExpand Up		@@ -1593,8 +1606,28 @@ mp_obj_t mp_import_from(mp_obj_t module, qstr name) {
		void mp_import_all(mp_obj_t module) {
		DEBUG_printf("import all %p\n", module);

		// TODO: Support __all__
		mp_map_t *map = &mp_obj_module_get_globals(module)->map;

		#if MICROPY_ENABLE_MODULE_IMPORT_ALL
		mp_map_elem_t *elem = mp_map_lookup(map, MP_OBJ_NEW_QSTR(MP_QSTR___all__), MP_MAP_LOOKUP);
		if (elem != NULL) {
		// When __all__ is defined, we must explicitly load all specified
		// symbols, possibly invoking the module __getattr__ function
		size_t len;
		mp_obj_t *items;
		mp_obj_get_array(elem->value, &len, &items);
		for (size_t i = 0; i < len; i++) {
		qstr qname = mp_obj_str_get_qstr(items[i]);
		mp_obj_t dest[2];
		mp_load_method(module, qname, dest);
		mp_store_name(qname, dest[0]);
		}
		return;
		}
		#endif

		// By default, the set of public names includes all names found in the module's
		// namespace which do not begin with an underscore character ('_')
		for (size_t i = 0; i < map->alloc; i++) {
		if (mp_map_slot_is_filled(map, i)) {
		// Entry in module global scope may be generated programmatically
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,59 @@
		# test `from package import *` conventions, including __all__ support
		#
		# This test requires MICROPY_CONFIG_ROM_LEVEL_AT_LEAST_BASIC_FEATURES

		try:
		next(iter([]), 42)
		except TypeError:
		# 2-argument version of next() not supported
		# we are probably not at MICROPY_CONFIG_ROM_LEVEL_BASIC_FEATURES
		print('SKIP')
		raise SystemExit

		# 1. test default visibility
		from pkgstar_default import *

		print('visibleFun' in globals())
		print('VisibleClass' in globals())
		print('_hiddenFun' in globals())
		print('_HiddenClass' in globals())
		print(visibleFun())

		# 2. test explicit visibility as defined by __all__ (as an array)
		from pkgstar_all_array import *

		print('publicFun' in globals())
		print('PublicClass' in globals())
		print('unlistedFun' in globals())
		print('UnlistedClass' in globals())
		print('_privateFun' in globals())
		print('_PrivateClass' in globals())
		print(publicFun())
		# test dynamic import as used in asyncio
		print('dynamicFun' in globals())
		print(dynamicFun())

		# 3. test explicit visibility as defined by __all__ (as an tuple)
		from pkgstar_all_tuple import *

		print('publicFun2' in globals())
		print('PublicClass2' in globals())
		print('unlistedFun2' in globals())
		print('UnlistedClass2' in globals())
		print(publicFun2())

		# 4. test reporting of missing entries in __all__
		try:
		from pkgstar_all_miss import *

		print("missed detection of incorrect __all__ definition")
		except AttributeError as er:
		print("AttributeError triggered for bad __all__ definition")

		# 5. test reporting of invalid __all__ definition
		try:
		from pkgstar_all_inval import *

		print("missed detection of incorrect __all__ definition")
		except TypeError as er:
		print("TypeError triggered for bad __all__ definition")
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,49 @@
		__all__ = ['publicFun', 'PublicClass', 'dynamicFun']


		# Definitions below should always be imported by a star import
		def publicFun():
		return 1


		class PublicClass:
		def __init__(self):
		self._val = 1


		# If __all__ support is enabled, definitions below
		# should not be imported by a star import
		def unlistedFun():
		return 0


		class UnlistedClass:
		def __init__(self):
		self._val = 0


		# Definitions below should be not be imported by a star import
		# (they start with an underscore, and are not listed in __all__)
		def _privateFun():
		return -1


		class _PrivateClass:
		def __init__(self):
		self._val = -1


		# Test lazy loaded function, as used by extmod/asyncio:
		# Works with a star import only if __all__ support is enabled
		_attrs = {
		"dynamicFun": "funcs",
		}


		def __getattr__(attr):
		mod = _attrs.get(attr, None)
		if mod is None:
		raise AttributeError(attr)
		value = getattr(__import__(mod, globals(), locals(), True, 1), attr)
		globals()[attr] = value
		return value
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,8 @@
		__all__ = ('existingFun', 'missingFun')


		def existingFun():
		return None


		# missingFun is not defined, should raise an error on import
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,22 @@
		__all__ = ('publicFun2', 'PublicClass2')


		# Definitions below should always be imported by a star import
		def publicFun2():
		return 2


		class PublicClass2:
		def __init__(self):
		self._val = 2


		# If __all__ support is enabled, definitions below
		# should not be imported by a star import
		def unlistedFun2():
		return 0


		class UnlistedClass2:
		def __init__(self):
		self._val = 0
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,20 @@
		# When __all__ is undefined, star import should only
		# show objects that do not start with an underscore


		def visibleFun():
		return 42


		class VisibleClass:
		def __init__(self):
		self._val = 42


		def _hiddenFun():
		return -1


		class _HiddenClass:
		def __init__(self):
		self._val = -1