Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.2k
tools/pyboard.py: Port recent patchs from mpremote serial transport, to add timeouts for non-responsive serial ports#17330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
dpgeorge wants to merge2 commits intomicropython:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This applies the mpremote commit0d46e45to pyboard.py.If the target does not return any data then `read_until()` will blockindefinitely. Fix this by making the initial read part of the general readlook, which always checks `inWaiting() > 0` before reading from the serialdevice.Also added the UART timeout to the constructor. This is not currently usedbut may be used as an additional safeguard.Signed-off-by: Damien George <damien@micropython.org>
This applies the mpremote commit03fe9c5to pyboard.py.The `timeout_overall` is used in `enter_raw_repl()`. It prevents waitingforever for a serial device that does not respond to the Ctrl-C/Ctrl-D/etccommands and is constantly outputting data.Signed-off-by: Damien George <damien@micropython.org>
Code size report: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #17330 +/- ##======================================= Coverage 98.54% 98.54% ======================================= Files 169 169 Lines 21897 21897 ======================================= Hits 21579 21579 Misses 318 318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This applies#16513 and#16616 (made for mpremote) to
tools/pyboard.py. They add timeouts to the initial connection phase to a target board, to help with non-responsive serial ports. Without these patchespyboard.pycan hang indefinitely waiting for a board to respond.Testing
To be tested by@hmaerki on Octoprobe.
Trade-offs and Alternatives
The test runners still use
pyboard.py. Eventually it would be good to change them to usempremoteas the backend, but that's a lot more effort.