- Notifications
You must be signed in to change notification settings - Fork8.2k
extmod/nimble: Add timeout to deinit.#17247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #17247 +/- ##======================================= Coverage 98.54% 98.54% ======================================= Files 169 169 Lines 21890 21898 +8 =======================================+ Hits 21572 21580 +8 Misses 318 318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code size report: |
extmod/nimble/modbluetooth_nimble.c Outdated
| @@ -629,13 +641,12 @@ int mp_bluetooth_init(void) { | |||
| // Run the scheduler while we wait for stack startup. | |||
| // On non-ringbuffer builds (NimBLE on STM32/Unix) this will also poll the UART and run the event queue. | |||
| mp_uint_ttimeout_start_ticks_ms = mp_hal_ticks_ms(); | |||
| volatilemp_uint_tstart = mp_hal_ticks_ms(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
volatile wasn't meant to be left here, I'll remove
Should extend this to more closely match the init functionality with regard to raising exceptions on failure |
b4e4528 tod33dd07CompareIf the BLE radio stops responding before deinit is called thefunction can get stuck waiting for an event that is never received,particularly if the radio is external or on a separate core.Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
d33dd07 to5ddd3d2Compare
Summary
If the BLE radio stops responding before deinit is called the function can get stuck waiting for an event that is never received, particularly if the radio is external or on a separate core.
This PR adds a timeout, similar to the timeout already used in the init function. That init function timeout was also
simplified as part of this change.
Relates to#17246
Testing
This has been tested on a stm32wb55 where the deinit was intermittently locking up waiting for the state to change.
This happened on a semi-regular basis on an application automated test suite which was running through hundreds of cycles over a number of hours.
Trade-offs and Alternatives
The main alternative to this is relying on watchdog to break the unit out of the infinite C loop once the failure occurs, but this is not appropriate for all applications.