Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

extmod/nimble: Add timeout to deinit.#17247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

andrewleech
Copy link
Contributor

Summary

If the BLE radio stops responding before deinit is called the function can get stuck waiting for an event that is never received, particularly if the radio is external or on a separate core.

This PR adds a timeout, similar to the timeout already used in the init function. That init function timeout was also
simplified as part of this change.

Relates to#17246

Testing

This has been tested on a stm32wb55 where the deinit was intermittently locking up waiting for the state to change.
This happened on a semi-regular basis on an application automated test suite which was running through hundreds of cycles over a number of hours.

Trade-offs and Alternatives

The main alternative to this is relying on watchdog to break the unit out of the infinite C loop once the failure occurs, but this is not appropriate for all applications.

@codecovCodecov
Copy link

codecovbot commentedMay 5, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base(ba92063) to head(d5f2fc2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@##           master   #17247   +/-   ##=======================================  Coverage   98.54%   98.54%           =======================================  Files         169      169             Lines       21898    21898           =======================================  Hits        21579    21579             Misses        319      319

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMay 5, 2025
edited
Loading

Code size report:

   bare-arm:    +0 +0.000% minimal x86:    +0 +0.000%    unix x64:    +0 +0.000% standard      stm32:    +0 +0.000% PYBV10     mimxrt:    +0 +0.000% TEENSY40        rp2:    +8 +0.001% RPI_PICO_W       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS  qemu rv32:    +0 +0.000% VIRT_RV32

@dpgeorgedpgeorge added the extmodRelates to extmod/ directory in source labelMay 6, 2025
@andrewleech
Copy link
ContributorAuthor

Should extend this to more closely match the init functionality with regard to raising exceptions on failure

@andrewleechandrewleechforce-pushed thenimble_deinit_timeout branch 3 times, most recently fromd33dd07 to5ddd3d2CompareMay 7, 2025 00:05
@andrewleechandrewleechforce-pushed thenimble_deinit_timeout branch 2 times, most recently from3a4c672 tob343d5bCompareMay 21, 2025 12:09
If the BLE radio stops responding before deinit is called the function canget stuck waiting for an event that is never received, particularly if theradio is external or on a separate core.This commit adds a timeout, similar to the timeout already used in the initfunction.  Updated for nimble, btstack, esp32 and zephyr bindings.Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
@dpgeorgedpgeorgeforce-pushed thenimble_deinit_timeout branch fromb343d5b tod5f2fc2CompareJune 3, 2025 16:23
@dpgeorgedpgeorge merged commitd5f2fc2 intomicropython:masterJun 3, 2025
59 of 63 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dpgeorgedpgeorgedpgeorge approved these changes

Assignees
No one assigned
Labels
extmodRelates to extmod/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@andrewleech@dpgeorge@pi-anl

[8]ページ先頭

©2009-2025 Movatter.jp