@dpgeorge BTW I haven't forgotten our discussion aboutnetwork_cyw43.h. I have a proposed refactor that covers this, but it turned out independent from this one.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base(45e4deb) to head(d00eab4).
Report is 2 commits behind head on master.

@@           Coverage Diff           @@##           master   #17092   +/-   ##=======================================  Coverage   98.54%   98.54%           =======================================  Files         169      169             Lines       21898    21898           =======================================  Hits        21580    21580             Misses        318      318

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Code size report:

   bare-arm:    +0 +0.000% minimal x86:    +0 +0.000%    unix x64:    +0 +0.000% standard      stm32:    +0 +0.000% PYBV10     mimxrt:    +0 +0.000% TEENSY40        rp2:    +0 +0.000% RPI_PICO_W       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS  qemu rv32:    +0 +0.000% VIRT_RV32

Note that the old cywbt.c driver will be replaced with a new BTHCI Uart backend that's been recently added to cyw43 driver, which requires some additional config option (no big changes, see#16848). The new Alif port already uses the new BTHCI backend, and it could be switch to the common config:https://github.com/micropython/micropython/blob/master/ports/alif/cyw43_configport.h

Sorry@projectgus but this now needs rebasing after merging#16848.

Some possible overlap between this andd6cfdca from#16057 ?

The new Alif port already uses the new BTHCI backend, and it could be switch to the common config

Sorry@projectgus but this now needs rebasing after merging#16848.

I've rebased on top the BTHCI changes, and migrated the Alif port to the common cyw43 config. All ports build after updating, but I only have hardware to test stm32 PYBD_SF2 (confirmed Wi-Fi & BLE both work but didn't run complete tests).

I think the BTHCI macros could also be put into the common config but have left it out of this PR for now, same as SDIO.

Some possible overlap between this andd6cfdca from#16057 ?

I think some overlap, but as those changes are scoped to rp2 I think they're more or less a subset of these.

EDIT: Oops it was a while since I looked, I think that change is mostly breaking out the mpconfig layer of CYW43 config. Whereas this change is refactoring the driver-facing layer of CYW43 config (i.e. the layer that translates the mpconfig settings to the driver). So mostly orthogonal.

I checked all changes for all the ports that I care about (so all except rp2), and they all look good. Also, I tested Alif port, and stm32 and both WiFi/BT are still working. I can't test mimxrt any time soon, maybe@kwagyeman can test it.

@iabdalkader - Pulled the latest of master of OpenMV, and then the micropython branched referenced, and applied the two commits and ran on the IMX. Bluetooth and WiFi both work.

Thanks@iabdalkader and@kwagyeman for testing the other ports. Have removed the duplicate definition and rebased.