Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.2k
rp2: Make result of thread.get_ident() a non-zero integer.#13413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CPython says thread identifier is a "nonzero integer", so rp2 should use a1-indexed core number rather than 0-indexed. This fixes thethread/thread_ident1 test failure on rp2 port.Unfortunately this may be a breaking change for rp2 code which makes ahard-coded comparison of thread identifier to 0 or 1.This work was funded through GitHub Sponsors.Signed-off-by: Angus Gratton <angus@redyak.com.au>
1d0335a tobdaea86CompareThank you! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
CPython says thread identifier is a "nonzero integer", so rp2 should use a 1-indexed core number rather than 0-indexed.
Fixes the thread/thread_ident1 test failure on rp2 port. Follow-up totests/thread: Adjust thread tests so most are able to run on rp2 port. #13351.
Unfortunately this may be a breaking change for any existing rp2 MP code which makes a hard-coded comparison of thread identifier to 0 or 1.
This work was funded through GitHub Sponsors.