- Notifications
You must be signed in to change notification settings - Fork1.3k
Implemented Ukkonen's algorithm for building suffix trees#208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Muhammad-Tayyab-Bhutto wants to merge2 commits intomgechev:masterChoose a base branch fromMuhammad-Tayyab-Bhutto:feat/implementation-of-ukkonen-algorithm-for-building-suffix-trees
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
###Overview:
This pull request introduces the implementation of Ukkonen's algorithm for building suffix trees, enhancing our project's capabilities in string processing and pattern matching.
Details:
Added a new JavaScript file, ukkonen-suffix-tree.js#20 , which contains the implementation of Ukkonen's algorithm for suffix tree construction.
Utilized ES6 best practices for coding, including class syntax, arrow functions, and the Map data structure.
Provided comprehensive comments within the code to enhance readability and maintainability.
Included relevant test cases to verify the correctness of the algorithm and ensure it functions as expected.
Motivation:
The motivation behind this implementation is to provide a powerful tool for efficient string processing and pattern matching within our project. Suffix trees have numerous applications, including text indexing, data compression, and bioinformatics, and Ukkonen's algorithm offers an optimized way to construct them.
Testing:
Comprehensive testing has been performed to validate the correctness and robustness of the implemented algorithm. Test cases cover a wide range of input scenarios and edge cases to ensure that the code functions as expected.
Contributor's Checklist:
Added the implementation of Ukkonen's algorithm for suffix tree construction.
Provided clear comments and documentation within the code.
Included relevant test cases.
Verified that the code passes all tests.
Followed ES6 best practices and modern JavaScript coding conventions.
Reviewer's Checklist:
Reviewed the code for correctness and adherence to best practices.
Checked the quality and coverage of test cases.
Assessed the clarity and completeness of comments and documentation.