- Notifications
You must be signed in to change notification settings - Fork97
fix(discovery): Do not fail if missing a subset of resources during API discover#406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(discovery): Do not fail if missing a subset of resources during API discover#406
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…PI discoverSigned-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
codecovbot commentedDec 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #406 +/- ##==========================================- Coverage 49.55% 49.52% -0.04%========================================== Files 54 54 Lines 3295 3297 +2 ========================================== Hits 1633 1633- Misses 1420 1422 +2 Partials 242 242
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading.Please reload this page.
AmitKumarDas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/LGTM
Provided some suggestions
Uh oh!
There was an error while loading.Please reload this page.
d025590 toaadc1bbCompareSigned-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
mikesmithgh commentedDec 6, 2021
Hi@grzesuav , would you be able to rerun the failing actions on this PR? I am able to run them successfully locally so I am not sure if there is just some flakiness going on or if my change would have any impact on the failiures. |
grzesuav commentedDec 7, 2021
🎉 This PR is included in version 2.0.18 🎉 The release is available onGitHub release Yoursemantic-release bot 📦🚀 |
The purpose of this PR is to avoid completely failing API discovery if only a subset of resources fail to be fetched.
In my particular case, another team managing keda-operator-metrics-apiserver occasionally goes into a bad state causing an error discovery resources. If metacontroller is starting up for the first time, then it will get an error fetching resources and be blocked until the keda operator is in a good state and responds with resources during API discovery.
{"level":"error","ts":1638640761.0517867,"msg":"Failed to fetch discovery info","error":"unable to retrieve the complete list of server APIs: external.metrics.k8s.io/v1beta1: the server is currently unable to handle the request","stacktrace":"metacontroller/pkg/dynamic/discovery.(*ResourceMap).Start.func1\n\t/go/src/metacontroller/pkg/dynamic/discovery/discovery.go:179"}