Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(discovery): Do not fail if missing a subset of resources during API discover#406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mikesmithgh
Copy link
Collaborator

The purpose of this PR is to avoid completely failing API discovery if only a subset of resources fail to be fetched.

In my particular case, another team managing keda-operator-metrics-apiserver occasionally goes into a bad state causing an error discovery resources. If metacontroller is starting up for the first time, then it will get an error fetching resources and be blocked until the keda operator is in a good state and responds with resources during API discovery.

{"level":"error","ts":1638640761.0517867,"msg":"Failed to fetch discovery info","error":"unable to retrieve the complete list of server APIs: external.metrics.k8s.io/v1beta1: the server is currently unable to handle the request","stacktrace":"metacontroller/pkg/dynamic/discovery.(*ResourceMap).Start.func1\n\t/go/src/metacontroller/pkg/dynamic/discovery/discovery.go:179"}

AmitKumarDas reacted with thumbs up emoji
…PI discoverSigned-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
@codecov
Copy link

codecovbot commentedDec 6, 2021
edited
Loading

Codecov Report

Merging#406 (a517d7b) intomaster (c93fb62) willdecrease coverage by0.03%.
The diff coverage is0.00%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #406      +/-   ##==========================================- Coverage   49.55%   49.52%   -0.04%==========================================  Files          54       54                Lines        3295     3297       +2     ==========================================  Hits         1633     1633- Misses       1420     1422       +2  Partials      242      242
FlagCoverage Δ
integration41.87% <0.00%> (-0.03%)⬇️
unit29.20% <0.00%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
pkg/dynamic/discovery/discovery.go76.92% <0.00%> (-2.03%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec93fb62...a517d7b. Read thecomment docs.

AmitKumarDas
AmitKumarDas previously approved these changesDec 6, 2021
Copy link
Contributor

@AmitKumarDasAmitKumarDas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

/LGTM
Provided some suggestions

@mikesmithghmikesmithghforce-pushed theignore-missing-k8s-resources branch 2 times, most recently fromd025590 toaadc1bbCompareDecember 6, 2021 18:22
Signed-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
@mikesmithgh
Copy link
CollaboratorAuthor

Hi@grzesuav , would you be able to rerun the failing actions on this PR? I am able to run them successfully locally so I am not sure if there is just some flakiness going on or if my change would have any impact on the failiures.

grzesuav reacted with thumbs up emoji

@grzesuavgrzesuav merged commitc40ab60 intometacontroller:masterDec 7, 2021
@grzesuav
Copy link
Contributor

🎉 This PR is included in version 2.0.18 🎉

The release is available onGitHub release

Yoursemantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AmitKumarDasAmitKumarDasAmitKumarDas left review comments

@grzesuavgrzesuavgrzesuav approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikesmithgh@grzesuav@AmitKumarDas

[8]ページ先頭

©2009-2025 Movatter.jp