- Notifications
You must be signed in to change notification settings - Fork72
test PR for release 0.9#1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:release/0.9
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
abffb4a to6805b52Compare| jobs: | ||
| generate-matrix: | ||
| uses:pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Make sure to rely on therelease/2.9 branch oftest-infra for all these yaml files. You'll also need to updatetest-infra-ref: main.
| [build-system] | ||
| requires = ["setuptools>=61.0"] | ||
| requires = ["setuptools>=69.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
were the changes above needed? I'm surprise we don't need them inmain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thelicense-files changes were needed to resolvethis error on python 3.14. On review, I am not certain that requires a newer version of setuptools, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is fishy (and sounds like a regression). We established thelicense-files = ["LICENSE"] way in#789
This is either a bug in setuptools, or we're doing something wrong here.
No description provided.