Restructure platformio.ini fornrf52_networking_base andnetworking_base to avoid double-defining dependencies and adopt the var naming convention used elsewhere in the project.

Old var	New var
`nrf52_networking_base`	`networking_base`
`networking_base`	`networking_extra`

networking_base (previouslynrf52_networking_base) will likely be used in the pioarduino porting efforts, genericizing the name makes sense.

fifieldt added the enhancementNew feature or request label

Dec 13, 2025

vidplace7 added cleanupCode cleanup or refactor and removed enhancementNew feature or request labels

Dec 13, 2025

vidplace7 requested a review frommverch67

December 13, 2025 20:51

vidplace7 force-pushed thenetworking_extra branch fromce629b7 to770ac87Compare

December 15, 2025 23:49

vidplace7 mentioned this pull request

Dec 16, 2025

Migrate esp32 families to pioarduino platform#8952

Draft

2 tasks

thebentern requested a review fromCopilot

December 16, 2025 01:34

Copilotstarted reviewing on behalf ofthebentern

December 16, 2025 01:34

View session

CopilotAI reviewed

Dec 16, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR restructures the PlatformIO networking dependency configuration to improve code reusability and eliminate duplication. The refactoring renamesnrf52_networking_base tonetworking_base (making it platform-agnostic), and extracts the Syslog dependency into a newnetworking_extra section for devices with sufficient flash space.

Key changes:

Renamednrf52_networking_base →networking_base to support broader platform use (e.g., pioarduino)
Renamednetworking_base →networking_extra and moved Syslog dependency to it
Updated all platform variants to reference the new naming scheme

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
platformio.ini	Core refactoring: defines`networking_base` (TBPubSubClient, NTPClient) and`networking_extra` (Syslog) sections
variants/nrf52840/rak_wismeshtap/platformio.ini	Updated to use renamed`networking_base` (no extra deps to save flash)
variants/nrf52840/rak4631/platformio.ini	Updated to use renamed`networking_base` (no extra deps to save flash)
variants/nrf52840/rak2560/platformio.ini	Updated to use renamed`networking_base` (no extra deps to save flash)
variants/rp2040/rpipicow/platformio.ini	Added`networking_extra` to include Syslog dependency
variants/rp2040/rak11310/platformio.ini	Added`networking_extra` to include Syslog dependency
variants/rp2350/rpipico2w/platformio.ini	Added`networking_extra` to include Syslog dependency
variants/native/portduino.ini	Added`networking_extra` to include Syslog dependency
variants/esp32/esp32.ini	Added`networking_extra` to include Syslog dependency