- Notifications
You must be signed in to change notification settings - Fork5.3k
Fix: Missing app_id on Neptune Analytics client#3278
Fix: Missing app_id on Neptune Analytics client#3278parshvadaftari merged 2 commits intomem0ai:mainfrom
Conversation
parshvadaftari left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Make changes in the mem0/graphs/configs.py as well
mem0/graphs/neptune/main.py Outdated
| graph_identifier = endpoint.replace("neptune-graph://", "") | ||
| self.graph = NeptuneAnalyticsGraph(graph_identifier) | ||
| self.graph = NeptuneAnalyticsGraph(graph_identifier = graph_identifier, | ||
| config = Config(user_agent_appid="Mem0")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No need to hard code this. We can make it configurable. You need to add app_id to the NeptuneConfig class and set this as a default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have updated the code to read from config, and has the constant for default value, would you mind to have another look?
Thanks!
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
4b2170e to7146bf9Compare
parshvadaftari left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me!
9337a87 intomem0ai:mainUh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Uh oh!
There was an error while loading.Please reload this page.
Description
Update langchain-aws client to send app_id, in order to facilitate client to monitor the resources usage.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist