Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix: Missing app_id on Neptune Analytics client#3278

Merged
parshvadaftari merged 2 commits intomem0ai:mainfrom
andy-k-improving:ft-hf-app-id
Aug 23, 2025
Merged

Fix: Missing app_id on Neptune Analytics client#3278
parshvadaftari merged 2 commits intomem0ai:mainfrom
andy-k-improving:ft-hf-app-id

Conversation

@andy-k-improving
Copy link
Contributor

@andy-k-improvingandy-k-improving commentedAug 5, 2025
edited
Loading

Description

Update langchain-aws client to send app_id, in order to facilitate client to monitor the resources usage.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Copy link
Contributor

@parshvadaftariparshvadaftari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Make changes in the mem0/graphs/configs.py as well

graph_identifier = endpoint.replace("neptune-graph://", "")
self.graph = NeptuneAnalyticsGraph(graph_identifier)
self.graph = NeptuneAnalyticsGraph(graph_identifier = graph_identifier,
config = Config(user_agent_appid="Mem0"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No need to hard code this. We can make it configurable. You need to add app_id to the NeptuneConfig class and set this as a default value.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have updated the code to read from config, and has the constant for default value, would you mind to have another look?
Thanks!

Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Copy link
Contributor

@parshvadaftariparshvadaftari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me!

@parshvadaftariparshvadaftari merged commit9337a87 intomem0ai:mainAug 23, 2025
6 of 7 checks passed
Echo0ff pushed a commit to Echo0ff/mem0 that referenced this pull requestAug 25, 2025
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
acarbonetto pushed a commit to acarbonetto/mem0 that referenced this pull requestSep 2, 2025
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
thestumonkey pushed a commit to Ushadow-io/mem0 that referenced this pull requestSep 7, 2025
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
jamesnavinhill pushed a commit to jamesnavinhill/ltm that referenced this pull requestSep 25, 2025
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

3 more reviewers

@bechbdbechbdbechbd approved these changes

@parshvadaftariparshvadaftariparshvadaftari approved these changes

@acarbonettoacarbonettoacarbonetto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andy-k-improving@bechbd@parshvadaftari@acarbonetto

Comments


[8]ページ先頭

©2009-2026 Movatter.jp