Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add namespace metadata option in templates#247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MannerMan wants to merge3 commits intomeilisearch:main
base:main
Choose a base branch
Loading
fromMannerMan:add-namespace-in-templates

Conversation

@MannerMan
Copy link

This sets the namespace key in metadata for all kubernetes manifests. The.Release.Namespace is a built-in variable in helm, that can be passed with--namespace oninstall ortemplate step. If not set it defaults todefault.

Why?

When usinghelm install with the--namespace argument the templates are applied into the chosen namespace.

When using helm only as a template engine, in combination with GitOps tools like Flux, the namespace property must be set in the rendered manifests to be applied. For--namespace to have an effect when usinghelm template, it must be present like this in the templates.

This change should not have any effect/change forhelm install approach as far as I know.

Pull Request

Related issue

Possibly a fix for#230

What does this PR do?

  • Sets the namespace key in metadata for all kubernetes manifests

PR checklist

Please check if your PR fulfills the following requirements:

  • [ x ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [ x ] Have you read the contributing guidelines?
  • [ x ] Have you made sure that the title is accurate and descriptive of the changes?

This sets the namespace key in metadata for all kubernetes manifests.The `.Release.Namespace` is a built-in variable in helm, that can bepassed with` --namespace` on `install` or `template` step. If not setit defaults to `default`.*Why?*When using `helm install` with the `--namespace` argument the templatesare applied into the chosen namespace.When using helm only as a template engine, in combination with GitOpstools like Flux, the namespace property must be set in the renderedmanifests to be applied. For `--namespace` to have an effect when using`helm template`, it must be present like this in the templates.This change should not have any effect/change for `helm install`approach as far as I know.
@brunoocasali
Copy link
Member

@meilisearch sync-manifest

Copy link
Member

@brunoocasalibrunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

bors merge

Thanks for this improvement@MannerMan :)

@brunoocasalibrunoocasali added the enhancementNew feature or request labelFeb 17, 2025
meili-borsbot added a commit that referenced this pull requestFeb 17, 2025
247: Add namespace metadata option in templates r=brunoocasali a=MannerManThis sets the namespace key in metadata for all kubernetes manifests. The `.Release.Namespace` is a built-in variable in helm, that can be passed with `--namespace` on `install` or `template` step. If not set it defaults to `default`.**Why?**When using `helm install` with the `--namespace` argument the templates are applied into the chosen namespace.When using helm only as a template engine, in combination with GitOps tools like Flux, the namespace property must be set in the rendered manifests to be applied. For `--namespace` to have an effect when using `helm template`, it must be present like this in the templates.This change should not have any effect/change for `helm install` approach as far as I know.# Pull Request## Related issuePossibly a fix for#230## What does this PR do?- Sets the namespace key in metadata for all kubernetes manifests## PR checklistPlease check if your PR fulfills the following requirements:- [ x ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?- [ x ] Have you read the contributing guidelines?- [ x ] Have you made sure that the title is accurate and descriptive of the changes?Co-authored-by: Oscar <oscar@eth1.nu>Co-authored-by: Bruno Casali <brunoocasali@gmail.com>Co-authored-by: brunoocasali <brunoocasali@users.noreply.github.com>
@meili-bors
Copy link
Contributor

Build failed:

@curquiza
Copy link
Member

@brunoocasali or@MannerMan can you fix the conflict please? sorry for that

@brunoocasali
Copy link
Member

This is a bit more complex than just fixing the conflicts@curquiza the change breaks the test, and I didn't find a solution at that time. I need to get back to this when I got some time :)

curquiza reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@brunoocasalibrunoocasalibrunoocasali approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MannerMan@brunoocasali@curquiza

[8]ページ先頭

©2009-2025 Movatter.jp