- Notifications
You must be signed in to change notification settings - Fork22
feat(macros): remove mdn-data dependency#390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
argl wants to merge6 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+530 −251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
This removes the dependency on mdn-data for the
{{cssinfo}}macro. Data now comes solely from the contents ofwebref/css, except for translations of the values. The latter are now in a new translation file, living incontent.This is about theFormal defintion blocks on the CSS reference pages. These show up potentially on CSS
propertiesand@-rule descriptors.The legacy mdn-data-sourced localizations contained md/html/macro-enhanced content at times, linking to the data via enumerations. These enumerations along with any localizations, are not available in webref/css. After discussion with the content team it was deemed to be more important to reflect the specs from webref/css properly than any markup-regression we will see with this new approach.
Caution
Should translations be unified? all in cssxref?
The keys are still translated as before, sourcing translations from …
The values are now translated from a new file in …
Motivation
Getting rid of mdn-data and go directly to the source.
Additional details
Related issues and pull requests
Fixes#369.