Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/fredPublic

fix(color-theme): show current theme in dropdown button#876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
brysonbw wants to merge2 commits intomdn:main
base:main
Choose a base branch
Loading
frombrysonbw:show-current-theme-on-the-color-theme-button

Conversation

@brysonbw
Copy link
Contributor

Description

Changes

  • show current theme on the color theme toggle button

Additional details

Screenshots and screen recordings

Before

image

After

current-theme-display.mov

Related issues and pull requests

#507

@brysonbwbrysonbw requested a review froma team as acode ownerOctober 7, 2025 03:01
@caugnercaugner changed the titlefix (ui): show current theme on the color theme toggle buttonfix(color-theme): show current theme in dropdown buttonOct 7, 2025
@caugner
Copy link
Contributor

@pepelsbey Is this solution what you had in mind?

@caugnercaugner added the needs content decisionThis issue needs a decision from the MDN Content Team before it can proceed. labelOct 7, 2025
@pepelsbey
Copy link
Member

pepelsbey commentedOct 7, 2025
edited
Loading

Thank you your help! Unfortunately, we might need to scale back the implementation a little. In the language switcher case, the language name is sufficient to represent what this dropdown is for. I'm afraid in the theme switcher's case, "Light", "Dark", or "OS default" might not look clear enough. Let's keep the "Theme" label and the appropriate icon next to it. In the original issue I filed,I pointed out that the current value is not available for screen readers, and this is the problem we need to address.

brysonbw reacted with thumbs up emoji

@brysonbw
Copy link
ContributorAuthor

For sure, all smooth

@caugnercaugner requested a review froma team as acode ownerOctober 23, 2025 11:46
@caugnercaugner requested a review fromLeoMcAOctober 23, 2025 11:46
@caugner
Copy link
Contributor

Converting to draft awaiting@pepelsbey's feedback to be addressed.

brysonbw reacted with thumbs up emoji

@caugnercaugner marked this pull request as draftOctober 23, 2025 11:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@LeoMcALeoMcAAwaiting requested review from LeoMcALeoMcA is a code owner automatically assigned from mdn/engineering

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

needs content decisionThis issue needs a decision from the MDN Content Team before it can proceed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brysonbw@caugner@pepelsbey

[8]ページ先頭

©2009-2025 Movatter.jp