- Notifications
You must be signed in to change notification settings - Fork22
fix(color-theme): show current theme in dropdown button#876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
fix(color-theme): show current theme in dropdown button#876
Uh oh!
There was an error while loading.Please reload this page.
Conversation
caugner commentedOct 7, 2025
@pepelsbey Is this solution what you had in mind? |
pepelsbey commentedOct 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you your help! Unfortunately, we might need to scale back the implementation a little. In the language switcher case, the language name is sufficient to represent what this dropdown is for. I'm afraid in the theme switcher's case, "Light", "Dark", or "OS default" might not look clear enough. Let's keep the "Theme" label and the appropriate icon next to it. In the original issue I filed,I pointed out that the current value is not available for screen readers, and this is the problem we need to address. |
brysonbw commentedOct 8, 2025
For sure, all smooth |
caugner commentedOct 23, 2025
Converting to draft awaiting@pepelsbey's feedback to be addressed. |
Description
Changes
Additional details
Screenshots and screen recordings
Before
After
current-theme-display.mov
Related issues and pull requests
#507