- Notifications
You must be signed in to change notification settings - Fork2.4k
Improve startViewTransition() data#28541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
chrisdavidmills wants to merge1 commit intomdn:mainChoose a base branch fromchrisdavidmills:update-document-startViewTransition
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Improve startViewTransition() data#28541
chrisdavidmills wants to merge1 commit intomdn:mainfromchrisdavidmills:update-document-startViewTransition
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
Tip: Review these changesgrouped by change (recommended for most PRs), orgrouped by feature (for large PRs). |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Chrome and Safari have both supported view transition types (seehttps://chromestatus.com/feature/5089552511533056) for a while, so it is high time I got them documented on MDN.
Having checked BCD, it seems that we have pretty much all of the data we need in place already, but I wanted to improve the
Document.startViewTransition()data:a.
updateCallbackmakes sense — this is the callback parameter mentioned in 1.b.
callbackOptionsdoesn't make sense. This refers to a mixin in the spec that represents the possible parameter values as one item. This is a spec construct and not a real value that developers can use. It would be better to have a sub-data point for the options object, with sub-sub-data points for the possible object properties. This last bit is maybe not totally necessary, but I thought it would be useful for developers who are specifically checking the compat table fortypessupport.This PR updates the data as described above, and also updates the spec URLs so they all point to the Level 2 of the spec
Test results and supporting details
Related issues