Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix tags for WebSocketStream#24913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
caugner merged 1 commit intomdn:mainfromskyclouds2001:WebSocketStream-tag
Nov 4, 2024

Conversation

@skyclouds2001
Copy link
Contributor

Summary

thetags should beweb-features:web-socket-stream, notweb-features:web-features:web-socket-stream

maybe a replace bug introduced in#22875

see alsohttps://websockets.spec.whatwg.org/ andwhatwg/websockets#48

Test results and supporting details

Related issues

@github-actionsgithub-actionsbot added the data:apiCompat data for Web APIs. https://developer.mozilla.org/docs/Web/API labelNov 2, 2024
@skyclouds2001skyclouds2001 marked this pull request as ready for reviewNovember 2, 2024 18:07
Copy link
Contributor

@caugnercaugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, thanks!

We should probably lint these eventually.

@caugnercaugner merged commit0b7db2a intomdn:mainNov 4, 2024
5 checks passed
@skyclouds2001
Copy link
ContributorAuthor

Good catch, thanks!

We should probably lint these eventually.

I guess it is possible to check if the tag is inhttps://github.com/web-platform-dx/web-features/

@skyclouds2001skyclouds2001 deleted the WebSocketStream-tag branchNovember 4, 2024 13:48
@skyclouds2001skyclouds2001 mentioned this pull requestNov 5, 2024
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@caugnercaugnercaugner approved these changes

Assignees

No one assigned

Labels

data:apiCompat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skyclouds2001@caugner
[8]ページ先頭
©2009-2025 Movatter.jp