Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add WebSocketStream#22875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Elchi3 merged 2 commits intomdn:mainfromElchi3:websocket-stream
Apr 22, 2024
Merged

Add WebSocketStream#22875

Elchi3 merged 2 commits intomdn:mainfromElchi3:websocket-stream
Apr 22, 2024

Conversation

@Elchi3
Copy link
Member

Discovered by the@openwebdocs BCD collector thanks toopenwebdocs/mdn-bcd-collector#1341.
No spec_url yet, seewhatwg/websockets#48

Adding the "websocket-stream" tag, sounds good Philip?

@Elchi3Elchi3 requested a review fromfoolipApril 18, 2024 14:46
@github-actionsgithub-actionsbot added the data:apiCompat data for Web APIs. https://developer.mozilla.org/docs/Web/API labelApr 18, 2024
@foolip
Copy link
Contributor

Adding the "websocket-stream" tag, sounds good Philip?

This is an interesting case. Because ofhttps://caniuse.com/websockets andhttps://websockets.spec.whatwg.org/ I would say that "websockets" is the best name for the base feature which goes back ages. But if we follow the style of turningCoolThing APIs into "cool-thing" identifiers, this should be "web-socket-stream". That looks weird alongside "websockets", but maybe that's OK.

We can always rename it later, but for now I guess I'd go with "web-socket-stream" based on theWebSocketStream API name. It helps that this is distinct from the oldWebSocket interface, and not astream property or something onWebSocket.

@Elchi3
Copy link
MemberAuthor

Thanks@foolip, I have no strong feelings about the id and accepted your suggestion. Merging this.

Do you want me to open a PR on web-features or do we have tooling in place that will signal to web-features that we have a new tag in BCD which will spawn something (automatically) over there?

@Elchi3Elchi3 merged commitdd678d2 intomdn:mainApr 22, 2024
@Elchi3Elchi3 deleted the websocket-stream branchApril 22, 2024 07:58
@foolip
Copy link
Contributor

@Elchi3 we don't have any tooling for this, but that would make a lot of sense. We could have a test that fails if there are any features in BCD that aren't in web-features, and a list for allowed exceptions which we could treat like a burndown list.

Elchi3 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@foolipfoolipfoolip approved these changes

Assignees

No one assigned

Labels

data:apiCompat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Elchi3@foolip

[8]ページ先頭

©2009-2025 Movatter.jp