- Notifications
You must be signed in to change notification settings - Fork2.4k
Correct the import assertions and attributes compat table#22821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
dandclark approved these changesApr 12, 2024
dandclark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for updating this! Just one minor correction.
Uh oh!
There was an error while loading.Please reload this page.
Elchi3 approved these changesApr 15, 2024
Member
Elchi3 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you! 👍
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
data:jsCompat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
The compat data for import assertions and attributes is out of date. This PR, hopefully, corrects it.
Some background info:
import ... from ... assert ...is now deprecated, but still implemented in Chromium (aka import assertions).import ... from ... with ...is the new way of doing this (aka import attributes).{type: json}or{type: css}. The latter is missing from BCD altogether.{type: json}.https://developer.apple.com/documentation/safari-release-notes/safari-17_2-release-notes#JavaScriptTest results and supporting details
I tested with a local HTML file on Chrome, Edge, Firefox, and Safari. And checkedchromestatus.com, and the Safari release notes linked above.