Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improvetests/subtests#163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Cadair merged 8 commits intomatplotlib:mainfromConorMacBride:improve-subtests
Jun 14, 2022
Merged

Conversation

@ConorMacBride
Copy link
Member

@ConorMacBrideConorMacBride commentedMay 27, 2022
edited
Loading

Now thetests/subtests can be updated/regenerated automatically without needing to manually adjust the baseline data.

To create the baseline images and hashes run:

MPL_UPDATE_BASELINE=1 tox -e mpl35

Then, to create the baseline summaries run:

MPL_UPDATE_SUMMARY=1 tox -e mpl35

Finally check thegit diff and run the standard tests before committing:

tox -e mpl35

I will add documentation for this in a README file intests/subtests.

All changes are isolated to withintests/subtests except I've addedPillow (imported asPIL) as a dependency. (Matplotlib already requires this package and#150 will need it also.) And I have made some minor changes totox.ini.

Interestingly, removing the matplotlib version number from the PNGs means thatall the hashes are identical across matplotlib 3.3, 3.4 and 3.5!! (I guess this isn't too surprising since the plots are very basic.)

  • Add documentation

Closes#159

bjlittle reacted with heart emoji
@bjlittlebjlittle mentioned this pull requestMay 28, 2022
16 tasks
@ConorMacBrideConorMacBride marked this pull request as ready for reviewMay 28, 2022 16:45
os.path.realpath(tempfile.gettempdir()),# replace all references to output files
]
REGEX_STRS= [
r'RMS Value: ',
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@bjlittle, in#150 this will need changed tor'RMS: '.

bjlittle reacted with thumbs up emoji
Copy link
Contributor

@bjlittlebjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@ConorMacBride Lovely. Looking forward to using this straight away for#150 👍

ConorMacBride reacted with rocket emoji
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
@ConorMacBride
Copy link
MemberAuthor

pre-commit.ci autofix

bjlittle reacted with laugh emojipre-commit-ci[bot] reacted with rocket emoji

@CadairCadair merged commit1c58479 intomatplotlib:mainJun 14, 2022
@ConorMacBrideConorMacBride deleted the improve-subtests branchFebruary 28, 2023 19:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bjlittlebjlittlebjlittle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reinstate sub-tests

3 participants

@ConorMacBride@bjlittle@Cadair

[8]ページ先頭

©2009-2025 Movatter.jp