- Notifications
You must be signed in to change notification settings - Fork49
Improvetests/subtests#163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| os.path.realpath(tempfile.gettempdir()),# replace all references to output files | ||
| ] | ||
| REGEX_STRS= [ | ||
| r'RMS Value: ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
bjlittle left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@ConorMacBride Lovely. Looking forward to using this straight away for#150 👍
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
ConorMacBride commentedMay 28, 2022
pre-commit.ci autofix |
for more information, seehttps://pre-commit.ci
Uh oh!
There was an error while loading.Please reload this page.
Now the
tests/subtestscan be updated/regenerated automatically without needing to manually adjust the baseline data.To create the baseline images and hashes run:
Then, to create the baseline summaries run:
Finally check the
git diffand run the standard tests before committing:I will add documentation for this in a README file in
tests/subtests.All changes are isolated to within
tests/subtestsexcept I've addedPillow(imported asPIL) as a dependency. (Matplotlib already requires this package and#150 will need it also.) And I have made some minor changes totox.ini.Interestingly, removing the matplotlib version number from the PNGs means thatall the hashes are identical across matplotlib 3.3, 3.4 and 3.5!! (I guess this isn't too surprising since the plots are very basic.)
Closes#159