- Notifications
You must be signed in to change notification settings - Fork22
Add doc hosting on readthedocs#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8378c88 to2c1bd8cCompareAs per#18 (comment), this isn't working and I'm going to close this PR. Bits can always be adapted for an attempt at hosting on GitHub pages. |
[pre-commit.ci] auto fixes from pre-commit.com hooksfor more information, seehttps://pre-commit.ci
| "image_scrapers": (qtgallery.qtscraper,), | ||
| "reset_modules": (qtgallery.reset_qapp,), | ||
| # Don't run any gallery examples, because they're not working on | ||
| # readthedocs at the moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
😭 But it was so nice.
What was the problem? I assume it's not a problem ofxfvb on rtd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure, butxvfb just kept crashing. Might be due to some leaking/non-closed widgets, but the error message wasn't helpful enough to make a more educated guess.
samcunliffeMay 10, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess we would needsudo access to a headless 18.04 VM to try it ourselves?
| tools: | ||
| python: "3.10" | ||
| apt_packages: | ||
| - xvfb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
... Andqtgallery's README says todo what you're doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Docs without pretty screenshots is better than no docs.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#18. This is a minimal config to get the docs building and hosted. The gallery build is disabled becaus I can't get it to work, but I think it's worth merging this as is so we can work on fixing the gallery and improving the rest of the docs in parallel.