Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve mypy type checking#82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
samcunliffe merged 2 commits intomatplotlib:mainfromdstansby:mypy
May 5, 2023
Merged

Conversation

dstansby
Copy link
Member

This turns on most of the recommendedmypy checks, and fixes a few things. There are two options that I've disabled in the config that I think would be more effor than they're worth to fix, because they involve interactions with stuff we're importing from outside packages that have incomplete typing.

Fixes#81

@dstansbydstansby marked this pull request as ready for reviewMay 5, 2023 08:45
Copy link
Collaborator

@samcunliffesamcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, unless you really don't want to fix theTODO: fix lines in which case I'd remove the TODOs.

@dstansby
Copy link
MemberAuthor

I guess ideally we would fix them in the future, but they're not high priority now, which is why I put the TODOs there.

samcunliffe reacted with thumbs up emoji

@samcunliffesamcunliffe added this pull request to the merge queueMay 5, 2023
Merged via the queue intomatplotlib:main with commit6b99b20May 5, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@samcunliffesamcunliffesamcunliffe approved these changes

@ruaridhgruaridhgAwaiting requested review from ruaridhg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type checking to pre-commit hooks
2 participants
@dstansby@samcunliffe
[8]ページ先頭
©2009-2025 Movatter.jp