Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

added colorsetting function#65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jo-mueller
Copy link
Contributor

@jo-muellerjo-mueller commentedFeb 13, 2023•
edited by dstansby
Loading

Fixes#64

I added a function to the plot base class that applies the functions pointed out by@haesleinhuepf inthis discussion. The function can then called whenever theself.axes object has been created in any plot class that was derived from the main class.

I put it as a draft PR since there are no tests yet. Also I think that it could be mentioned in the contribution guidelines that new widgets should call this method afterself.canvas.figure.add_subplot() has been called.

Let me know what you think :)

@jo-muellerjo-mueller marked this pull request as ready for reviewMarch 3, 2023 08:59
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A couple of minor changes, and a suggestion for iterating through the spines. Otherwise looking 👍 (and sorry about how long it's taken me to get to this, if you want me to finish this off just let me know!)

@dstansby
Copy link
Member

Ooh also a rebase would be good to check thatpre-commit is happy!

@jo-mueller
Copy link
ContributorAuthor

jo-mueller commentedMay 2, 2023•
edited
Loading

Hi@dstansby ,

thanks for the feedback, I incorporated your suggestions. The last commit was me not realizing thatset_tight_layout() had been deprecated when I rebased my branch ^^"

PS: I edited the PR message so that both#36 and#64 will be closed by this PR as they both address the same issue.

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks 👍 - not sure this does fix#36, as there hasn't been amatplotlibrc file added. That's fine for now, but I'll make sure that issue doesn't get closed when I merge this 😄

@dstansbydstansby added this to the0.3.0 milestoneMay 2, 2023
@dstansbydstansby merged commite1d3c50 intomatplotlib:mainMay 2, 2023
@jo-muellerjo-mueller deleted the fix-default-colorscheme branchMay 3, 2023 07:56
@jo-muellerjo-mueller mentioned this pull requestMay 3, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

importing napari-matplotlib modifies how plots are shown in jupyter notebooks
2 participants
@jo-mueller@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp