Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support napari>=0.5#274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 11 commits intomatplotlib:mainfromdstansby:napari-05
Oct 1, 2024
Merged

Support napari>=0.5#274

dstansby merged 11 commits intomatplotlib:mainfromdstansby:napari-05
Oct 1, 2024

Conversation

dstansby
Copy link
Member

@dstansbydstansby commentedJul 12, 2024
edited by samcunliffe
Loading

@dstansbydstansby added this to the3.0 milestoneJul 12, 2024
@samcunliffe
Copy link
Collaborator

The tests fail because of this (significant) diff in the data ...

result-failed-diff

baseline

result

@samcunliffe
Copy link
Collaborator

@dstansby I claim a fix here 🚀

The

OverflowError: Python integer -1 out of bounds for uint8

was fixed by -1 → -1.0 🙃

I've somehow managed to push to your fork, so I can approve this, but I'll wait foryou to click merge.
(Also, we need to be sure to squash merge because there are images changed and changed back in the history here.)

jni reacted with heart emoji

@samcunliffesamcunliffe self-requested a reviewOctober 1, 2024 09:04
@samcunliffesamcunliffe added Maintenance dependenciesPull requests that update a dependency file labelsOct 1, 2024
@samcunliffe
Copy link
Collaborator

pre-commit.ci autofix

pre-commit-ci[bot] reacted with rocket emoji

@samcunliffe
Copy link
Collaborator

pre-commit.ci run

pre-commit-ci[bot] reacted with rocket emoji

@dstansby
Copy link
MemberAuthor

I think the mypy error is because pre-commit is running a version of numpy (I can't work out which...) that doesn't have ashape argument tonp.reshape(), which indeed seems only to have been added in 2.1.0:numpy/numpy#26292. I think we want to support older numpy versions than that, so I think the fix is to revert to using thenewshape argument, and ignoring the deprecation warning (for now, until we depend on numpy>=2.1)

samcunliffe reacted with thumbs up emoji

@samcunliffe
Copy link
Collaborator

so I think the fix is to revert to using thenewshape argument, and ignoring the deprecation warning (for now, until we depend on numpy>=2.1)

Thanks for the detective work! I was just playing 🔨

@dstansbydstansby merged commit7e860f5 intomatplotlib:mainOct 1, 2024
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@samcunliffesamcunliffesamcunliffe approved these changes

Labels
dependenciesPull requests that update a dependency fileMaintenance
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

2 participants
@dstansby@samcunliffe

[8]ページ先頭

©2009-2025 Movatter.jp