Pytest: I rewrote the existing tests a bit to make them more specific to vectors/points/other future supported layer and updated the respective baseline images. However, I didn't get the tests to pass with the call topytest --mpl - it's probably the same issue as inthis PR.
Interactive test: I checked in the viewer that all controls behave as expected.

jo-mueller added8 commits

October 4, 2023 12:49

added basic coloring to histogram

064252b

Create test.ipynb

42ce86d

changed color properties of correct layer

ee4f9a8

used correct refresh functions to make it work for different layer types

206f71f

made specific tests for every layer type

e3540c3

updated baselines

d65da10

removed labels from supported layers

b6312c3

Delete test.ipynb

073613c

Copy link

ContributorAuthor

jo-mueller commentedOct 4, 2023

pre-commit.ci autofix

pre-commit-cibotand others added2 commits

October 4, 2023 14:47

[pre-commit.ci] auto fixes from pre-commit.com hooks

7179889

for more information, seehttps://pre-commit.ci

removed main from test

e7789a0

Copy link

Member

dstansby commentedOct 8, 2023

I've just fixed some failing tests (due to a new Matplotlib release) at#217, so worth merging or rebasing main.

jo-mueller added2 commits

October 8, 2023 20:32

Merge branch 'main' into color-histogram-bars

001dbca

re-saved generated figures

5b87710

Copy link

ContributorAuthor

jo-mueller commentedOct 8, 2023•
edited
Loading

@dstansby

Strange. The figures in thebaseline folders were saved from the tests themselves using

deepcopy(fig).savefig('./baseline/name_of_test_function.png')

but this generates an incorrect figures size, as it seems. Is there a correct way to save the generated test figures?

As for the other failing tests, I merged the current head into this branch but am not sure why tests are failing.

Copy link

ContributorAuthor

jo-mueller commentedOct 26, 2023

Hi@dstansby ,

could you give me a hint on how to properly create the figures needed for the test to make the checks pass? Would be much appreciated :)

dstansby added2 commits

November 2, 2023 15:06

Merge branch 'main' into color-histogram-bars

5df6b6b

Update test figures

6d37c78

Copy link

Member

Ithink the test figures were in the right place, but just needed updating due to changes that happened between opening the PR and now. I've merged in main, and updated the figures, so lets see if the tests pass now 😄