Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Line plot widget with features#184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

zoccoler
Copy link
Contributor

Hi@dstansby ,

As discussed in a previous#63 , I have updated and re-factored the previous code to add a line widget! 📈 🚀

  • TheLineBaseWidget just usesplot, similar to theSliceWidget, but without spinboxes. It is used as base by the following classes.
  • TheLineWidget uses theShapes layer to plot intensities from a selected Image layer. So far, it only works with the shapeline. I had to makea small change inbase because ofthis line. I am using thebezier_curve from scikit-image to get pixel coordinates. There is no interpolation in this current implementation.
  • TheFeaturesLineWidget is similar to theFeaturesScatterWidget, but it has a third dropdown to group plots by a 'label' column.

I provided 3 minimal examples and gifs to show how it looks like. I believe theFeaturesLineWidget gets interesting, for example, when one has features over time. It also works for single time points, although I think a scatter plot would make more sense then.

I am particularly interested in using the LineWidget and the FeaturesLineWidget in other plugins I am working on.

Lastly, I tried to make them minimal and generalizable, but I have some difficulties setting what is minimal 😅 . I think I can count on your experience to help me there.

Best,
Marcelo

zoccolerand others added7 commitsOctober 28, 2022 17:06
Co-authored-by: David Stansby <dstansby@gmail.com>
- make LineBaseWidget- make LineWidget for plotting intensities under shapes layer- make FeaturesLineWidget for plotting features from labels layer (grouped by a label column matching labels in layer)
@dstansby
Copy link
Member

Thanks for the clear description, examples and gifs! I like both these a lot, and the code looks good too 👍 . I think I will need to do more thinking about theLineWidget, so would you be happy to put the base widget at theFeaturesLineWidget in a separate PR? I think I could review/merge/release that fairly quickly, without discussions about theLineWidget holding it up.

@zoccolerzoccoler mentioned this pull requestJul 29, 2023
@zoccoler
Copy link
ContributorAuthor

Alright, I just opened#200 for that, thanks!

@zoccoler
Copy link
ContributorAuthor

Closing this, updates can be found in#200

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@zoccoler@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp