Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow style sheets to be used#175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
samcunliffe merged 4 commits intomatplotlib:mainfromdstansby:stylesheetss
Jun 21, 2023

Conversation

dstansby
Copy link
Member

@dstansbydstansby commentedJun 19, 2023
edited
Loading

This is a minimum viable implementation for using Matplotlb style sheets. Currently light and dark style sheets are hardcoded (taken from#157), instead of being generated from the napari theme. I think this is a better approach, as even though it's less general, I doubt the napari folks will be changing their theme very often so manually updating our theme when they do is a reasonable ask.

This doesn't deal with whether we should look for user style sheets, but does let the users set the style sheet property with a path to their own style sheet. We can follow this PR up with a PR to add a location where users can put a custom style sheet.

This still needs:

samcunliffe reacted with heart emoji
@dstansbydstansby marked this pull request as ready for reviewJune 20, 2023 08:26
Copy link
Collaborator

@samcunliffesamcunliffe left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🍉🍉 I like this very much. I'm particularly pleased that you took the stuff I started and made it good/work.

  • Do we want to add something to the docs to explain how to add a custom stylesheet by setting thewidget.mpl_style_sheet_path?

@samcunliffe
Copy link
Collaborator

samcunliffe commentedJun 20, 2023
edited
Loading

Just for my sanity:#160 which ispassing here is sufficient.

@samcunliffe
Copy link
Collaborator

Let's close#156 and#157 as this supersedes them.

We can follow this PR up with a PR to add a location where users can put a custom style sheet.

Wemight want to steal the idea from#156 to use a special theme installed in the user's mpl config dir? How do you feel about that?

@samcunliffesamcunliffe added this pull request to the merge queueJun 21, 2023
Merged via the queue intomatplotlib:main with commit1f05e06Jun 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@samcunliffesamcunliffesamcunliffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dstansby@samcunliffe

[8]ページ先頭

©2009-2025 Movatter.jp