- Notifications
You must be signed in to change notification settings - Fork22
Allow style sheets to be used#175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
samcunliffe left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🍉🍉 I like this very much. I'm particularly pleased that you took the stuff I started and made it good/work.
- Do we want to add something to the docs to explain how to add a custom stylesheet by setting the
widget.mpl_style_sheet_path
?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
samcunliffe commentedJun 20, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Just for my sanity:#160 which ispassing here is sufficient. |
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
This is a minimum viable implementation for using Matplotlb style sheets. Currently light and dark style sheets are hardcoded (taken from#157), instead of being generated from the napari theme. I think this is a better approach, as even though it's less general, I doubt the napari folks will be changing their theme very often so manually updating our theme when they do is a reasonable ask.
This doesn't deal with whether we should look for user style sheets, but does let the users set the style sheet property with a path to their own style sheet. We can follow this PR up with a PR to add a location where users can put a custom style sheet.
This still needs: