Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add inheritance graphs to docs#171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 5 commits intomatplotlib:mainfromdstansby:inheritance-graphs
Jun 15, 2023

Conversation

dstansby
Copy link
Member

Fixes#169. Here's what it looks like rendered locally for me:

Screenshot 2023-06-15 at 10 01 01

@dstansbydstansby changed the titleInheritance graphsAdd inheritance graphs to docsJun 15, 2023
@samcunliffe
Copy link
Collaborator

samcunliffe commentedJun 15, 2023•
edited
Loading

Yeah, do you think it's worthwhile?
Since#168 there is now some relatively interesting class structure.

Also: custom plot users will need to inherit from...SingleAxisWidget now, right?

@dstansby
Copy link
MemberAuthor

I think it's worth it, especially if#167 happens and it gets even moreinteresting

Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
@dstansbydstansbyenabled auto-mergeJune 15, 2023 09:38
@samcunliffe
Copy link
Collaborator

Do we need@ruaridhg because: co-authored commit?

@dstansby
Copy link
MemberAuthor

I think I hit the merge buton, it's just waiting for tests.

@dstansby
Copy link
MemberAuthor

@samcunliffe can you try giving this a fresh approve?

samcunliffe reacted with thumbs up emojisamcunliffe and ruaridhg reacted with rocket emoji

@dstansbydstansby added this pull request to the merge queueJun 15, 2023
Merged via the queue intomatplotlib:main with commite6446fcJun 15, 2023
@ruaridhg
Copy link
Collaborator

Diagram looks good!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@samcunliffesamcunliffesamcunliffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add inheritance graphs to docs
3 participants
@dstansby@samcunliffe@ruaridhg
[8]ページ先頭
©2009-2025 Movatter.jp