- Notifications
You must be signed in to change notification settings - Fork22
Don't duplicate CI on merge to main#161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -2,8 +2,6 @@ name: tests | |||
| on: | |||
| push: | |||
| branches: | |||
| - main | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I claim this will make it even harder to solve#155 because then there'll beno builds reporting the coverage frommain. It's good from a 🌱 perspective though. No need to duplicate server work.
Happy to approve as an experiment, but I'm still betting on myif: ${{ !contains(github.ref, 'gh-readonly-queue/') }} as more likely to solve. (Unfortunately, any play tests have to go ontomain, by construction.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, that's a good point. Lets hold off on merging this, and I'll dive into the codecov docs to see what they recommend re. merge queues?
Replaced by#170 |
Uh oh!
There was an error while loading.Please reload this page.
Currently it looks like CI is run on both push to main, and merge_group via the merge queue. This PR removes that duplication by not running CI on push to main.
Possibly related to#155??