- Notifications
You must be signed in to change notification settings - Fork22
Napari light dark themes as stylesheets instead of set up by hand.#157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
samcunliffe wants to merge3 commits intomatplotlib:mainfromsamcunliffe:napari-light-dark-themes-as-stylesheets-2-86
Closed
Napari light dark themes as stylesheets instead of set up by hand.#157
samcunliffe wants to merge3 commits intomatplotlib:mainfromsamcunliffe:napari-light-dark-themes-as-stylesheets-2-86
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
A TDD test to check we can set the theme from a user-defined stylesheet.For this, just use Solarized_Light2.
... with their own custom stylesheet. At the moment this must be called'user.mplstyle' in the cwd.
Follows on frommatplotlib#2 andmatplotlib#86. We can remove the hard-coded theme setup andmove to using matplotlib stylesheets (napari-dark.mplstyle andnapari-light.mplstyle) instead. The caveat is that this means the pluginis _less_ flexible when presented with a weird and wonderful user theme.
| f"Napari theme '{self.viewer.theme}' is not supported by" | ||
| " napari-matplotlib. Will fall back to the matplotlib default." | ||
| ) | ||
| matplotlib.style.use("default") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here is where we're now less flexible. I figured we should fallback to the default mpl style ☝️
We could also do something more complicated withself._theme_has_light_bg and choosing a light or dark mpl style to contrast.
Closing in favour of#175 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
A dependent draft PR (sorry!) following on from#156.
Only pay attention to6166de7 (the previous two commits should disappear after rebasing).
Summary
Wecould copy the dark and light napari themes as mplstyle files and match the theme to the plot style.
Depends on
Follows on from:
Reviewer notes
We mightnot want to do this: it would mean that we're less flexible when a user defines their own napari theme (the previous way, of interrogating the
napari.themeto manually set plot style was agnostic to whether the napari theme was stock or custom).On the plus side: the code is simpler, and it separates aesthetics from function.