- Notifications
You must be signed in to change notification settings - Fork22
A simple test ofNapariNavigationToolbar._update_buttons_checked
.#153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
dstansby merged 1 commit intomatplotlib:mainfromsamcunliffe:test-toolbar-icons-change-when-selectedJun 12, 2023
Merged
A simple test ofNapariNavigationToolbar._update_buttons_checked
.#153
dstansby merged 1 commit intomatplotlib:mainfromsamcunliffe:test-toolbar-icons-change-when-selectedJun 12, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
A (slightly) dumb pixel-by-pixel test that the checked and uncheckedicons are different.
def _are_different(a: QImage, b: QImage) -> bool: | ||
""" | ||
Check that a and b are identical, pixel by pixel. Via a stupid nested for loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
Checkthataandbareidentical,pixelbypixel.Viaastupidnestedforloop. | |
Checkthataandbarenotidentical,pixelbypixel.Viaastupidnestedforloop. |
dstansby approved these changesJun 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Inspired by the codecov report, the
_update_buttons_checked
method of theNapariNavigationToolbar
isuntested. So here's a (slightly) dumb UI test.If anyone knows a better way to compare two
QImage
s I'm really open to it.Buuuut itdoes seem like a nested
for
loop is the simplest way to do this. (For reference:there seems to be an unlooping way to shove the data into anumpy array
, but it involves pointers, and I'm not sure it's more readable. Readability counts?) Idid check the time and the loopy way in this PR is ones of milliseconds.Testing:
Things I've done:
QImage.save
to dump the images.return True
withNotes for reviewers:
As mentioned: I am not a fan of the nested for loops.
Low priority and independent test. So don't rush to review this. It's unlikely to conflict 👍 .