Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

3D scatter test#152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ruaridhg merged 8 commits intomatplotlib:mainfromruaridhg:scatter-test-3D-data
Jun 2, 2023
Merged

Conversation

ruaridhg
Copy link
Collaborator

Closes#8

  • Added test_scatter_3D with brain_data
  • Changed slice number to 9 so it was different from default to check test

Potential remaining tasks (@dstansby):

  • Should I switch the default slice number for the 3D histogram and 3D slice tests?
  • Not sure how to implement a 3D features scatter (is this necessary?)

@dstansby
Copy link
Member

Should I switch the default slice number for the 3D histogram and 3D slice tests?

Do you think there's a benefit to doing this (e.g. is it testing something that wouldn't be tested if the slice isn't changed)? If so I'd say go for it!

Not sure how to implement a 3D features scatter (is this necessary?)

Ithink features data is always 2D, so we don't have to worry about 3D tests for that.

ruaridhg reacted with hooray emoji

@ruaridhgruaridhgenabled auto-mergeJune 2, 2023 13:28
@ruaridhgruaridhg requested a review fromdstansbyJune 2, 2023 14:04
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • One comment to remove
  • Isn'tbrain_data[0] an array already, so it shouldn't need casting to an array?

@ruaridhgruaridhg requested a review fromdstansbyJune 2, 2023 14:29
@ruaridhgruaridhg added this pull request to the merge queueJun 2, 2023
Merged via the queue intomatplotlib:main with commit7f675f2Jun 2, 2023
@ruaridhgruaridhg deleted the scatter-test-3D-data branchJune 2, 2023 14:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test with 2D and 3D data
2 participants
@ruaridhg@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp