- Notifications
You must be signed in to change notification settings - Fork22
Add scatter figure test#137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works for me locally!
I think the tests are failing because a similar issue to#129 where the order is inconsistent so generating the test figure can switch from astronaut vs astronaut_reversed to astronaut_reversed vs astronaut meaning the image comparison fails |
I'm guessing that's because the selected layers are stored in a |
To give the layers a deterministic order, I've sorted them by their name - do you think that's a good soluiton? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It works for the tests, but does that mean that it will always plot based on alphabetical order rather than order of selecting within napari? I guess it's still probably worth merging for now
Uh oh!
There was an error while loading.Please reload this page.
Adds a figure test for scattering two images against each other.
The fix to previous issues we were having was adding the line
widget = ScatterWidget(viewer). For some reason, storing the widget in a variable instead of just doingfigure = ScatterWidget(viewer).figuremakes the callbacks work properley... I'm not entirely sure why, and I don't propose to enter that rabbit hole.