Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add reports from pytest-mpl, changed setup and tox#131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 7 commits intomatplotlib:mainfromruaridhg:report_artefact
May 19, 2023

Conversation

ruaridhg
Copy link
Collaborator

@ruaridhgruaridhg commentedMay 19, 2023
edited
Loading

Closes#97

  • 2D and 3D pytest-mpl reports added for histogram and slice with html summaryfig_comparison.html
  • matplotlib added to setup.cfg testing
  • cp and ls commands added to tox and mpl-result-path set in tox

@ruaridhgruaridhg requested a review fromdstansbyMay 19, 2023 12:09
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't want to commit an individual report from a test run to the repository - the report should be generated during testing (either locally or on GitHub actions), and then we want to upload that as an artefact at the end of the GitHub actions run.

So I think the TODO here is (let me know if this doesn't make sense or you think otherwise!):

  • Undo adding thereport directory, and put backreport in gitignore
  • Add a step at the end of the GH actions run that uploads the wholereport directory usingactions/upload-artifact

@ruaridhg
Copy link
CollaboratorAuthor

We don't want to commit an individual report from a test run to the repository - the report should be generated during testing (either locally or on GitHub actions), and then we want to upload that as an artefact at the end of the GitHub actions run.

So I think the TODO here is (let me know if this doesn't make sense or you think otherwise!):

  • Undo adding thereport directory, and put backreport in gitignore
  • Add a step at the end of the GH actions run that uploads the wholereport directory usingactions/upload-artifact

I was actually just thinking the same thing so will add the upload-artifact step

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Noice, looking good!
Screenshot 2023-05-19 at 16 54 28

@dstansbydstansby added this pull request to the merge queueMay 19, 2023
Merged via the queue intomatplotlib:main with commit231d77dMay 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest-mpl report out from tox and upload it as a build artefact in the CI
2 participants
@ruaridhg@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp