Add test_scatter.png so tox passes in other branch#123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ruaridhg wants to merge1 commit intomatplotlib:mainfromruaridhg:upload_scatterwidget_2Dtest

Closed

Add test_scatter.png so tox passes in other branch#123

ruaridhg wants to merge1 commit intomatplotlib:mainfromruaridhg:upload_scatterwidget_2Dtest

Conversation

Copy link

Collaborator

ruaridhg commentedMay 18, 2023•
edited
Loading

Refers to#122
Want to merge this branch to add test_scatter.png so I can run tox for the scatter_test.py in another branch

Add test_scatter.png so tox passes in other branch

b08a5ff

ruaridhg requested a review fromdstansby

May 18, 2023 14:26

Copy link

Member

dstansby commentedMay 18, 2023

I'm confused by this PR - why is there a test image without a corresponding figure test?

Copy link

CollaboratorAuthor

ruaridhg commentedMay 18, 2023

I'm confused by this PR - why is there a test image without a corresponding figure test?

I've tested locally and it produced this test image. When tox runs on the test_scatter on the other PR#121 it copies the baseline folder which doesn't contain this image so tox fails. This was me trying to find a workaround to upload the test image prior to test on the other branch/PR, but if it's too hacky I can try to figure out another way for it to work. It may be running pytest-mpl twice in the tox file