Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fig test slice#113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 7 commits intomatplotlib:mainfromruaridhg:fig_test_slice
May 17, 2023
Merged

Fig test slice#113

dstansby merged 7 commits intomatplotlib:mainfromruaridhg:fig_test_slice
May 17, 2023

Conversation

ruaridhg
Copy link
Collaborator

@ruaridhgruaridhg commentedMay 15, 2023
edited by dstansby
Loading

Towards#8

  • Added baseline folder with test images to gitignore
  • test_slice used 3D brain data from ski image
  • needed to change backend_qt5agg to backend_qtagg (not sure if this is something we want in the base.py since the change was just for testing)

@ruaridhgruaridhg marked this pull request as ready for reviewMay 15, 2023 14:17
Copy link
Member

@dstansbydstansby left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The test is now skipped during testing, and it shouldn't be skipped. (e.g. seehttps://github.com/matplotlib/napari-matplotlib/actions/runs/4981454254/jobs/8915726820?pr=113#step:7:42)

I suspect this is because there aren't any baseline images? Instead of gitignoring the test image folder, I think we decided to upload the test images to the repo, so the gitignore needs changing, and the baseline test images adding.

@ruaridhg
Copy link
CollaboratorAuthor

The test is now skipped during testing, and it shouldn't be skipped. (e.g. seehttps://github.com/matplotlib/napari-matplotlib/actions/runs/4981454254/jobs/8915726820?pr=113#step:7:42)

I suspect this is because there aren't any baseline images? Instead of gitignoring the test image folder, I think we decided to upload the test images to the repo, so the gitignore needs changing, and the baseline test images adding.

Locally it seems to skip the first time when creating the baseline image and then it works as expected the 2nd time, but clearly is not the case for tox so will investigate further. Yes, I remember now and I've found a 3D image that works then makes sense to remove from gitignore.

@dstansby
Copy link
Member

👍 - I think the two things that need doing then are:

  • Commit the test images to the git repository
  • Make sure the test images are available to tox. It might be you need to copy them from the root of the repostiory to the tox environment with a command in the tox file that looks like:
    cp {toxinidir}/path/to/figures/in/repo {envdir}/path/to/figures/in/repo
    (I got the tox variables in curly brackets fromhttps://tox.wiki/en/latest/config.html)

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The test is still being skipped, I'm guessing because it still isn't finding the test image?

@ruaridhg
Copy link
CollaboratorAuthor

The test is still being skipped, I'm guessing because it still isn't finding the test image?

Yes, I've not got it quite working yet as using tox locally, the test_slice is being skipped due toUnable to download data/brain.tiff so I need to locate that and copy it over to tox

dstansby reacted with thumbs up emoji

@ruaridhg
Copy link
CollaboratorAuthor

@dstansby Turns outpython -c 'from skimage import data; data.brain()' was the command needed to make the data available to tox. Should be fine to merge now, however Read the Docs build failed

@dstansbydstansby added this pull request to the merge queueMay 17, 2023
@dstansbydstansby mentioned this pull requestMay 17, 2023
6 tasks
Merged via the queue intomatplotlib:main with commite8c276cMay 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dstansbydstansbydstansby approved these changes

@samcunliffesamcunliffeAwaiting requested review from samcunliffe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ruaridhg@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp