- Notifications
You must be signed in to change notification settings - Fork22
Fix leaky QT widgets#108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMay 15, 2023
Closed
1123512 to92186d1CompareI've managed to fix them all, apart from |
Merged
215e185 to221e479CompareFix parent typingFix QWidget import
fda8647 to1a7324dCompareruaridhg approved these changesMay 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR enables a check for leaky QT widgets. This is done in
conftest.pyby setting the "NAPARI_STRICT_QT" environment variable during the tests.To make the the widgets watertight I had to do two things:
parentkeyword argument to make sure all widgets have a parent widget. This is important, because parent widgets will pro-actively close any of their children when they themselves are closed.magicgui. Previously there was a circular reference that prevented the widget and one of the menusmagicguicreated from being cleaned up. I think the new code is a bit more readable if anything, and makes it clear where callbacks are between the combo boxes and the graph drawing. To test this runexamples/features_scatter.pyand have a play around with the widget.Fixes#109