- Notifications
You must be signed in to change notification settings - Fork22
Description
Relatively minor, and I think it's something to do with the merge queue's autobranches.
The codecovlanding page for this project should show the coverage at the "latest" commit onmain
. Which it claims is9598eeb
However, that was the middle of last week. There don't seem to be any relevant changes after or around this commit inour history (the next PR to be merged intomain
was#146 which doesn't touch the coverage or the ci).
Note that allcommits' builds onmain
actuallyhave sent coverage reports to codecov. They are coming from the merge queue's auto-generated branches and when the build reruns onmain
, it seems somehow that thegh-readonly-queue/
branch is given precedence.
Not sure if this can be fixed with a setting in codecov. Possibly we could skip coverage upload by hacking our CI yml with something like:
-name:Upload coverage report (skip if this is a merge queue build)if:${{ !contains(github.ref, 'gh-readonly-queue/') }}uses:codecov/codecov-action@v2
For thecoverage step. Assuming that it reruns the build as onmain
.
Unsure if related, but (since I'm digging in the codecov uploads) we have encounteredcodecov/3954 a few times. They recommend using a codecov upload token even if the repo is public.