Commita922dd6

authored

only reset bin number when layer selection is valid (#315)

1 parentf5451e5 commita922dd6Copy full SHA for a922dd6

File tree

+14

-7

lines changed

+14

-7

lines changed

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,15 +99,12 @@ def on_update_layers(self) -> None:`
`99`	`99`	`Called when the selected layers are updated.`
`100`	`100`	`"""`
`101`	`101`	`super().on_update_layers()`
`102`		`-ifself._valid_layer_selection:`
	`102`	`+ifself._valid_layer_selectionandself.layers:`
`103`	`103`	`self.layers[0].events.contrast_limits.connect(self._update_contrast_lims)`
`104`	`104`
`105`		`-ifnotself.layers:`
`106`		`-return`
`107`		`-`
`108`		`-# Reset the num bins based on new layer data`
`109`		`-layer_data=self._get_layer_data(self.layers[0])`
`110`		`-self._set_widget_nums_bins(data=layer_data)`
	`105`	`+# Reset the num bins based on new layer data`
	`106`	`+layer_data=self._get_layer_data(self.layers[0])`
	`107`	`+self._set_widget_nums_bins(data=layer_data)`
`111`	`108`
`112`	`109`	`def_update_contrast_lims(self)->None:`
`113`	`110`	`forlim,lineinzip(`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -164,3 +164,13 @@ def test_change_contrast(make_napari_viewer, astronaut_data):`
`164`	`164`	`# update contrast limits of image layer, and check no errors are thrown`
`165`	`165`	`image_layer=viewer.layers[0]`
`166`	`166`	`image_layer.contrast_limits= [2,50]`
	`167`	`+`
	`168`	`+`
	`169`	`+deftest_select_labels_layer(make_napari_viewer):`
	`170`	`+"""Test that no errors are thrown when the Histogram widget`
	`171`	`+ is opened with a labels layer selected."""`
	`172`	`+viewer=make_napari_viewer()`
	`173`	`+viewer.add_labels(np.ones(shape=(5,5,5),dtype="uint8"))`
	`174`	`+`
	`175`	`+widget=HistogramWidget(viewer)`
	`176`	`+viewer.window.add_dock_widget(widget)`

Comments

(0)