Commit9067a2d

committed

Don't allow bins lower than 0 if dtype is unisgned

1 parentd589d5f commit9067a2dCopy full SHA for 9067a2d

File tree

2 files changed

+14

-9

lines changed

examples
- histogram.py
src/napari_matplotlib
- histogram.py

2 files changed

+14

-9

lines changed

`‎examples/histogram.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`importnapari`
`6`	`6`
`7`	`7`	`viewer=napari.Viewer()`
`8`		`-viewer.open_sample("napari","kidney")`
	`8`	`+viewer.open_sample("napari","coins")`
`9`	`9`
`10`	`10`	`viewer.window.add_plugin_dock_widget(`
`11`	`11`	`plugin_name="napari-matplotlib",widget_name="Histogram"`

`‎src/napari_matplotlib/histogram.py‎`

Lines changed: 13 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ def __init__(`
`46`	`46`	`bins_start.setStepType(QAbstractSpinBox.AdaptiveDecimalStepType)`
`47`	`47`	`bins_start.setRange(-1e10,1e10)`
`48`	`48`	`bins_start.setValue(0)`
`49`		`-bins_start.setWrapping(True)`
	`49`	`+bins_start.setWrapping(False)`
`50`	`50`	`bins_start.setKeyboardTracking(False)`
`51`	`51`	`bins_start.setDecimals(2)`
`52`	`52`
`@@ -55,6 +55,7 @@ def __init__(`
`55`	`55`	`bins_stop.setStepType(QAbstractSpinBox.AdaptiveDecimalStepType)`
`56`	`56`	`bins_stop.setRange(-1e10,1e10)`
`57`	`57`	`bins_stop.setValue(100)`
	`58`	`+bins_start.setWrapping(False)`
`58`	`59`	`bins_stop.setKeyboardTracking(False)`
`59`	`60`	`bins_stop.setDecimals(2)`
`60`	`61`
`@@ -148,13 +149,17 @@ def on_update_layers(self) -> None:`
`148`	`149`	`self.autoset_widget_bins(data=layer_data)`
`149`	`150`
`150`	`151`	`# Only allow integer bins for integer data`
	`152`	`+# And only allow values greater than 0 for unsigned integers`
`151`	`153`	`n_decimals=0ifnp.issubdtype(layer_data.dtype,np.integer)else2`
`152`		`-self.findChild(QDoubleSpinBox,name="bins start").setDecimals(`
`153`		`-n_decimals`
`154`		`- )`
`155`		`-self.findChild(QDoubleSpinBox,name="bins stop").setDecimals(`
`156`		`-n_decimals`
`157`		`- )`
	`154`	`+is_unsigned=layer_data.dtype.kind=="u"`
	`155`	`+minimum_value=0ifis_unsignedelse-1e10`
	`156`	`+`
	`157`	`+bins_start=self.findChild(QDoubleSpinBox,name="bins start")`
	`158`	`+bins_stop=self.findChild(QDoubleSpinBox,name="bins stop")`
	`159`	`+bins_start.setDecimals(n_decimals)`
	`160`	`+bins_stop.setDecimals(n_decimals)`
	`161`	`+bins_start.setMinimum(minimum_value)`
	`162`	`+bins_stop.setMinimum(minimum_value)`
`158`	`163`
`159`	`164`	`defdraw(self)->None:`
`160`	`165`	`"""`
`@@ -169,7 +174,7 @@ def draw(self) -> None:`
`169`	`174`	`self.bins_start,`
`170`	`175`	`self.bins_stop,`
`171`	`176`	`self.bins_num,`
`172`		`-dtype=intifnp.issubdtype(data.dtype,np.integer)elsefloat,`
	`177`	`+dtype=data.dtype,`
`173`	`178`	`)`
`174`	`179`
`175`	`180`	`iflayer.rgb:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9067a2d

File tree

2 files changed

2 files changed

`‎examples/histogram.py‎`

`‎src/napari_matplotlib/histogram.py‎`

0 commit comments