- Notifications
You must be signed in to change notification settings - Fork668
added vlines feature to plotting.py#570
Open
deepchandra02 wants to merge 6 commits intomatplotlib:masterfrom
Open
added vlines feature to plotting.py#570deepchandra02 wants to merge 6 commits intomatplotlib:masterfrom
deepchandra02 wants to merge 6 commits intomatplotlib:masterfrom
Conversation
DanielGoldfarb requested changesNov 14, 2022
Collaborator
DanielGoldfarb left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- You need to remove the
buildanddistdirectories from the repository. (build and dist directories should never be committed to a repository). test.py
a. needs a better name
b. there should not be two copies of the same file in two different locations.
c. if test.py is intended to be part of the regular regression tests, then it should be modeled after, and follow a similar pattern as, the other existing test files.- Both
pr569_testing.ipynbandtesting_issue551.ipynbshould be moved into the following directory:examples/scratch_pad/issues/. Also, once you move them there, you may have to modify the input data paths, so that those notebooks still run in this new location.
Please make the above mentioned changes in order to continue with this Pull Request.
Thank you.
| else: | ||
| panels = _build_panels(fig, config) | ||
| axA1 = panels.at[config['main_panel'],'axes'][0] | ||
| warnings.warn(f"this type is {type(axA1)}") |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why this line of code??
| """ | ||
| import sys | ||
| sys.stdout = sys.__stdout__ |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why these two lines of code??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this is an enhancement request based off of the request:#513
Please review the code and let us know if it is acceptable for merge! This is for our course project, I hope this helps :)