Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ENH: link stable sitemap#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 5 commits intomatplotlib:masterfromjklymak:enh-link-stable-sitemap
Jan 21, 2021

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedJan 19, 2021•
edited
Loading

Much pared-down version of#47.

Instead of redirecting the whole root tree, it now simply takes root out of the canonical search path insitemap.xml androbots.txt, and instead suggests going to the softlinkedstable->3.3.3.sitemap.xml androbots.txt would need to be manually updated at release (though robots.txt should be fine until Matplotlib 6).

Todo:

  • canonical links will still need to point tomatplotlib.org/stable/

@jklymak
Copy link
MemberAuthor

Someone who understandssitemap.xml androbots.txt better than me should definitely jump in here if they don't think this will work....

@jklymak
Copy link
MemberAuthor

BTW do we want /stable/ or /latest/? I guess I like/stable/ as a parallel to/dev/ however, I probably typed/latest/ 50% of the time working on this...

@dstansby
Copy link
Member

BTW do we want /stable/ or /latest/? I guess I like/stable/ as a parallel to/dev/ however, I probably typed/latest/ 50% of the time working on this...

Definitelystable, by default on readthedocs (which many many many python projects use)stable means the latest release, andlatest means the latest commit on the main branch.

p.s. I'm half following all of this, thanks a lot for the PRs!

jklymak and story645 reacted with thumbs up emoji

@jklymakjklymakforce-pushed theenh-link-stable-sitemap branch from2df234b toe0a5434CompareJanuary 19, 2021 16:24

<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<url>
<loc>http://matplotlib.org/stable/</loc>
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note these should really have a<last-modified> tag, but I think they will work without.

@jklymakjklymak linked an issueJan 19, 2021 that may beclosed by this pull request
@jklymak
Copy link
MemberAuthor

A way forward to redirect root level instead of replacing root level by soft links tostable (#47) would be to figure out the newest version (usualstable, but other versions if the file is now removed) and replace all the root level html files with a refresh:

<!DOCTYPE HTML><htmllang="en"><head><metacharset="utf-8"><metahttp-equiv="refresh"content="0;url={{NEWEST_VERSION}}/PATH"/><linkrel="canonical"href="{{NEWEST_VERSION}}/PATH"/></head><body><h1>                                                                                The page been moved to<ahref="{{NEWEST_VERSION}}/PATH"</a></h1></body></html>

Yet another option is change the hosting from GitHub pages, and be able to include our own.htaccess

@QuLogic
Copy link
Member

QuLogic commentedJan 20, 2021•
edited
Loading

This seems pretty reasonable, but all I did was read the docs that you linked, so I don't know about the SEO implications.

You may have missed a few project subdirectories:

  • /matplotblog definitely should be crawled
  • /pytest-mpl has agh-pages branch, but seems to be broken
  • /basemap maybe should still be crawled
  • /cycler should be crawled
  • /mpl-altair might be a bit dead, but can still be crawled
  • /mpl-bench needs to be automated, but can be crawled
  • /devdocs could be crawled, but should be marked as updated daily at least

I have some ideas of how to proceed on the redirects now, but no time to try them just yet. Maybe after the 3.4.0 release candidate.

@jklymak
Copy link
MemberAuthor

Great I can add those. But how do you know those are all there? I can see how the main docs are built, but how do the other ones get injected? Do they just have GitHub pages that deploy onto ours?

@QuLogic
Copy link
Member

Any repo atgithub.com/USER/REPO deploys toUSER.github.io/REPO when it has agh-pages branch. We just also have a CNAME setup to usematplotlib.org instead ofUSER.github.io. I'm not actually sure what happens if the main site has a page calledREPO that would shadow the repo-specific one.

jklymak reacted with thumbs up emoji

@jklymakjklymak mentioned this pull requestJan 21, 2021
@tacaswelltacaswell merged commit17652c7 intomatplotlib:masterJan 21, 2021
@jklymakjklymak deleted the enh-link-stable-sitemap branchJanuary 21, 2021 21:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicAwaiting requested review from QuLogic

@tacaswelltacaswellAwaiting requested review from tacaswell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

root pages should redirect to versioned pages
4 participants
@jklymak@dstansby@QuLogic@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp