Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BUG: clear events before destroying windows in tkagg#9956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfrommattip:tkagg-issue9856
Dec 13, 2017
Merged

BUG: clear events before destroying windows in tkagg#9956

tacaswell merged 1 commit intomatplotlib:masterfrommattip:tkagg-issue9856
Dec 13, 2017

Conversation

mattip
Copy link
Contributor

Fixes issue#9856 by clearing events while destroying.

Alternative implementation: callflush_events() inclose_events() inFigureCanvasAgg, which might help other backends?

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@mattip
Copy link
ContributorAuthor

There seem to be a number of issues related to TkAgg and the message loop:#9856,#8129,#9077,#8845.
Since AFAICT pull requests#9275,#9356 seem to be approved, could they be merged to master? It would make determining how this pull request affects the other issues easier.

@jklymak
Copy link
Member

This works fine for me on OS X, with no unsightly messages.

@tacaswelltacaswell added this to thev2.2 milestoneDec 8, 2017
@anntzer
Copy link
Contributor

anntzer commentedDec 9, 2017•
edited
Loading

This is not fixed by#9275 (dunno, just asking)?

@jklymak
Copy link
Member

No. I was testing off master and got those errors

@duynguyenhoang
Copy link

Fixed#9856 for me
get_backend() == TkAgg
MacOS 10.12.6
Python 3.6.2

@anntzeranntzer mentioned this pull requestDec 11, 2017
6 tasks
@tacaswelltacaswell merged commit2132073 intomatplotlib:masterDec 13, 2017
@tacaswell
Copy link
Member

May not be the perfect solution, but is an improvement over status-quo.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

7 participants
@mattip@jklymak@anntzer@duynguyenhoang@tacaswell@QuLogic@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp