Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX/TST: update tests for pandas 0.21#9726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 1 commit intomatplotlib:masterfromjklymak:fixpandas
Nov 10, 2017

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedNov 9, 2017•
edited
Loading

This shouldfix#9610.

As of pandas 0.21,import pandas no longer calls

frompandas.tseriesimportconverterconverter.register()

so it has been added to the tests.

Surprisingly no examples depend on pandas, so that made life simpler.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant

@jklymakjklymak added this to thev2.1.1 milestoneNov 9, 2017
@jklymakjklymak added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelNov 9, 2017
@@ -5073,6 +5077,9 @@ def test_pandas_indexing_dates():

def test_pandas_errorbar_indexing():
pd = pytest.importorskip('pandas')
from pandas.tseries import converter
converter.register()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PEP8 doesn't like this blank line, otherwise tests seem to be fine.

jklymak reacted with thumbs up emoji
@story645
Copy link
Member

story645 commentedNov 9, 2017•
edited
Loading

so unclear if this code actually reduces coverage or if it's an artifact of a different PR.

@dstansby
Copy link
Member

Sometimes I feel like I need an undergraduate degree in codecov just to understand codecov...

I think the issue is that there are two tests both namedtest_pandas_bar_align_center() so only one is collected and run.@jklymak would you mind quickly changing the name of one of them here?

story645 reacted with thumbs up emoji

@jklymak
Copy link
MemberAuthor

Huh, did I do that? Anyhow, should be fixed now barring other foolishness

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 happy for this to go in once tests pass - at least now we can start testing on latest version of pandas again whilst discussing what to do about unit support

@story645story645 merged commit91e4bee intomatplotlib:masterNov 10, 2017
@tacaswell
Copy link
Member

@meeseeksdev backport to v2.1.x

@lumberbot-app
Copy link

There seem to be a conflict, please backport manually

tacaswell pushed a commit that referenced this pull requestNov 10, 2017
FIX/TST: update tests for pandas 0.21Conflicts:    .appveyor.yml       conflicts due thrashing around pandas version pinning
@tacaswell
Copy link
Member

manually backported viace45bea

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.topic: testing
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.

provide converters for datetime64 types
4 participants
@jklymak@story645@dstansby@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp